[3dprinter-general] Bug#1054697: slic3r-prusa: FTBFS: test_arrange.cpp:1:10: fatal error: catch2/catch.hpp: No such file or directory

[Gregor Riepl]

Hi,

> If that's an intentional upstream change, reassigning to catch2 won't
> help as it's not a bug in that package.

Got it.

In the meantime, I prepared a patch to fix compatibility with Catch2 v3 
(attached). I haven't submitted it upstream yet, but I'd appreciate any 
feedback.

The biggest changes were around floating point value comparisons.
I had to tweak some unit tests, because the previous approximations in 
Catch2 are no longer available, and the replacement functionality uses a 
different algorithm. In fact, there's three algorithms now, and I chose 
the one that seems most appropriate to me for what slic3r does. I 
believe there is no change in correctness, the results should be well 
within acceptable limits.

Regards,
Greg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Catch2-v3-updates.patch
Type: text/x-patch
Size: 72382 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/3dprinter-general/attachments/20231101/83802b33/attachment-0003.bin>