[Android-tools-devel] Bug#1042042: android-platform-build: FTBFS: Vector.h:259:28: error: cannot convert ‘const android::Vector<TYPE>*’ to ‘android::VectorImpl*’

[Lucas Nussbaum]

Source: android-platform-build
Version: 1:10.0.0+r36-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> g++ tools/zipalign/ZipAlign.cpp tools/zipalign/ZipEntry.cpp tools/zipalign/ZipFile.cpp -o zipalign -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -I/usr/include/android -Wl,-z,relro -Wl,-z,now -fPIC -Wl,-rpath=/usr/lib/x86_64-linux-gnu/android -lpthread -lzopfli -lz -L/usr/lib/x86_64-linux-gnu/android -lutils -llog -landroidfw -lbacktrace -lziparchive
> In file included from tools/zipalign/ZipFile.h:24,
>                  from tools/zipalign/ZipAlign.cpp:20:
> /usr/include/android/utils/Vector.h: In member function ‘const android::Vector<TYPE>& android::Vector<TYPE>::operator=(const android::Vector<TYPE>&) const’:
> /usr/include/android/utils/Vector.h:259:28: error: cannot convert ‘const android::Vector<TYPE>*’ to ‘android::VectorImpl*’
>   259 |     VectorImpl::operator = (static_cast<const VectorImpl&>(rhs));
>       |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/android/utils/Vector.h:25:
> /usr/include/android/utils/VectorImpl.h:56:59: note:   initializing argument 'this' of ‘android::VectorImpl& android::VectorImpl::operator=(const android::VectorImpl&)’
>    56 |             VectorImpl&     operator = (const VectorImpl& rhs);
>       |                                         ~~~~~~~~~~~~~~~~~~^~~
> /usr/include/android/utils/Vector.h: At global scope:
> /usr/include/android/utils/Vector.h:397:80: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   397 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_construct(void* storage, size_t num) const {
>       |                                                                                ^~~~~
> /usr/include/android/utils/Vector.h:407:90: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   407 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_copy(void* dest, const void* from, size_t num) const {
>       |                                                                                          ^~~~~
> /usr/include/android/utils/Vector.h:412:91: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   412 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_splat(void* dest, const void* item, size_t num) const {
>       |                                                                                           ^~~~~
> /usr/include/android/utils/Vector.h:417:98: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   417 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_move_forward(void* dest, const void* from, size_t num) const {
>       |                                                                                                  ^~~~~
> /usr/include/android/utils/Vector.h:422:99: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   422 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_move_backward(void* dest, const void* from, size_t num) const {
>       |                                                                                                   ^~~~~
> In file included from tools/zipalign/ZipFile.h:24,
>                  from tools/zipalign/ZipFile.cpp:26:
> /usr/include/android/utils/Vector.h: In member function ‘const android::Vector<TYPE>& android::Vector<TYPE>::operator=(const android::Vector<TYPE>&) const’:
> /usr/include/android/utils/Vector.h:259:28: error: cannot convert ‘const android::Vector<TYPE>*’ to ‘android::VectorImpl*’
>   259 |     VectorImpl::operator = (static_cast<const VectorImpl&>(rhs));
>       |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/android/utils/Vector.h:25:
> /usr/include/android/utils/VectorImpl.h:56:59: note:   initializing argument 'this' of ‘android::VectorImpl& android::VectorImpl::operator=(const android::VectorImpl&)’
>    56 |             VectorImpl&     operator = (const VectorImpl& rhs);
>       |                                         ~~~~~~~~~~~~~~~~~~^~~
> /usr/include/android/utils/Vector.h: At global scope:
> /usr/include/android/utils/Vector.h:397:80: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   397 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_construct(void* storage, size_t num) const {
>       |                                                                                ^~~~~
> /usr/include/android/utils/Vector.h:407:90: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   407 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_copy(void* dest, const void* from, size_t num) const {
>       |                                                                                          ^~~~~
> /usr/include/android/utils/Vector.h:412:91: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   412 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_splat(void* dest, const void* item, size_t num) const {
>       |                                                                                           ^~~~~
> /usr/include/android/utils/Vector.h:417:98: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   417 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_move_forward(void* dest, const void* from, size_t num) const {
>       |                                                                                                  ^~~~~
> /usr/include/android/utils/Vector.h:422:99: warning: ‘cfi’ attribute directive ignored [-Wattributes]
>   422 | UTILS_VECTOR_NO_CFI void Vector<TYPE>::do_move_backward(void* dest, const void* from, size_t num) const {
>       |                                                                                                   ^~~~~
> tools/zipalign/ZipFile.cpp: In member function ‘void* android::ZipFile::uncompress(const android::ZipEntry*) const’:
> tools/zipalign/ZipFile.cpp:1294:30: error: cannot declare variable ‘reader’ to be of abstract type ‘FileReader’
>  1294 |             const FileReader reader(mZipFp);
>       |                              ^~~~~~
> tools/zipalign/ZipFile.cpp:1221:7: note:   because the following virtual functions are pure within ‘FileReader’:
>  1221 | class FileReader : public zip_archive::Reader {
>       |       ^~~~~~~~~~
> In file included from tools/zipalign/ZipFile.cpp:24:
> /usr/include/android/ziparchive/zip_archive.h:337:16: note:     ‘virtual bool zip_archive::Reader::ReadAtOffset(uint8_t*, size_t, off64_t) const’
>   337 |   virtual bool ReadAtOffset(uint8_t* buf, size_t len, off64_t offset) const = 0;
>       |                ^~~~~~~~~~~~
> make[2]: *** [debian/zipalign.mk:10: build] Error 1


The full build log is available from:
http://qa-logs.debian.net/2023/07/24/android-platform-build_10.0.0+r36-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.