[From nobody Fri Jul 24 18:51:03 2026
Received: (at submit) by bugs.debian.org; 24 Jul 2026 16:53:21 +0000
X-Spam-Checker-Version: SpamAssassin 4.0.1-bugs.debian.org_2005_01_02
 (2024-03-25) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.0 required=4.0 tests=BAYES_00,FROMDEVELOPER,
 NO_RELAYS,XMAILER_REPORTBUG autolearn=ham autolearn_force=no
 version=4.0.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 22; hammy, 149; neutral, 35; spammy,
 1. spammytokens:0.941-+--H*r:bugs.debian.org
 hammytokens:0.000-+--H*Ad:N*Bug, 0.000-+--HTo:N*Debian,
 0.000-+--HTo:N*System, 0.000-+--HTo:N*Bug, 0.000-+--HTo:N*Tracking
Return-path: <nadzeya@debian.org>
Received: via submission by buxtehude.debian.org with esmtp (Exim 4.96)
 (envelope-from <nadzeya@debian.org>) id 1wnJ9E-00GV8U-0p
 for submit@bugs.debian.org; Fri, 24 Jul 2026 16:53:21 +0000
Content-Type: multipart/mixed; boundary="===============2232051828860360448=="
MIME-Version: 1.0
From: Nadzeya Hutsko <nadzeya@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: openboard: will FTBFS with poppler 26.07
Message-ID: <178491199794.213982.11341913108615903119.reportbug@debian>
X-Mailer: reportbug 13.2.0
Date: Fri, 24 Jul 2026 18:53:17 +0200
Delivered-To: submit@bugs.debian.org

This is a multi-part MIME message sent by reportbug.


--===============2232051828860360448==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Source: openboard
Version: 1.7.7+dfsg-1
Severity: normal
Tags: ftbfs patch

Dear Maintainer,

openboard will FTBFS against poppler 26.07 (currently in experimental)
once it reaches unstable:

```
src/pdf/XPDFRenderer.cpp:182:49: error: base operand of '->' has
non-pointer type 'const std::string'
  182 |     return QString(title.getString()->c_str());
```

poppler 26.04 changed Object::getString() to return a const std::string&
instead of a GooString*, so title.getString()->c_str() no longer
compiles.

The attached patch adds a version-guarded branch that uses the value's
.c_str(), following the existing POPPLER_VERSION_MAJOR/MINOR convention,
so older poppler still builds. The change is fully guarded on
POPPLER_VERSION, so it is a no-op with the poppler currently in unstable
and can be applied now, ahead of the transition

Thanks
Nadzeya

--===============2232051828860360448==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="1009_fix-ftbfs-with-poppler-26.07.patch"

Description: Fix FTBFS with poppler 26.04+
 poppler 26.04 changed Object::getString() to return a const
 std::string& instead of a GooString*, so title.getString()->c_str()
 no longer compiles.  Add a version-guarded branch using the value's
 .c_str(), following the existing POPPLER_VERSION_MAJOR/MINOR
 convention, so older poppler still builds
Author: Nadzeya Hutsko <nadzeya@ubuntu.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/2161747
Forwarded: no
Last-Update: 2026-07-24
--- a/src/pdf/XPDFRenderer.cpp
+++ b/src/pdf/XPDFRenderer.cpp
@@ -178,7 +178,10 @@
 #endif
             if (title.isString())
             {
-#if POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 72
+#if POPPLER_VERSION_MAJOR > 26 || (POPPLER_VERSION_MAJOR == 26 && POPPLER_VERSION_MINOR >= 4)
+                // poppler 26.04 made Object::getString() return a const std::string&
+                return QString(title.getString().c_str());
+#elif POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 72
                 return QString(title.getString()->c_str());
 #else
                 return QString(title.getString()->getCString());

--===============2232051828860360448==--
]