[Debian-ha-maintainers] Bug#1048033: sbd: Fails to build source after successful build

[Lucas Nussbaum]

Source: sbd
Version: 1.5.2-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package sbd
> dpkg-buildpackage: info: source version 1.5.2-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Valentin Vidic <vvidic at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in src
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> rm -rf .libs _libs
>  rm -f sbd
> rm -f *.o
> rm -f *.lo
> rm -f *.tab.c
> test -z "sbd.service sbd_remote.service sbd.sh sbd.sysconfig" || rm -f sbd.service sbd_remote.service sbd.sh sbd.sysconfig
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> rm -f ./.deps/sbd-cluster.Po
> rm -f ./.deps/sbd-common.Po
> rm -f ./.deps/sbd-inquisitor.Po
> rm -f ./.deps/sbd-md.Po
> rm -f ./.deps/sbd-pacemaker.Po
> rm -f ./.deps/setproctitle.Po
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> Making distclean in agent
> make[2]: Entering directory '/<<PKGBUILDDIR>>/agent'
> rm -rf .libs _libs
> rm -f *.lo
> test -z "sbd" || rm -f sbd
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/agent'
> Making distclean in man
> make[2]: Entering directory '/<<PKGBUILDDIR>>/man'
> rm -rf .libs _libs
> rm -f *.lo
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> test -z "sbd.8.pod sbd.8 sbd.sysconfig.pod" || rm -f sbd.8.pod sbd.8 sbd.sysconfig.pod
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/man'
> Making distclean in tests
> make[2]: Entering directory '/<<PKGBUILDDIR>>/tests'
> test -z "libsbdtestbed.la" || rm -f libsbdtestbed.la
> rm -rf .libs _libs
> rm -f *.o
> rm -f ./so_locations
> rm -f *.lo
> rm -f *.tab.c
> test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> rm -f ./.deps/sbd-testbed.Plo
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/tests'
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> test -z "*.rpm *.tar.* sbd-*" || rm -f *.rpm *.tar.* sbd-*
> rm -rf .libs _libs
> rm -f *.lo
> test -z "sbd.pc" || rm -f sbd.pc
> rm -f config.h stamp-h1
> test . = "." || test -z "" || rm -f 
> rm -f libtool config.lt
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test -z "sbd-* sbd-*/" || rm -f sbd-* sbd-*/
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building sbd using existing ./sbd_1.5.2.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  sbd-1.5.2/tests-opt.m4
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/sbd_1.5.2-1.diff.CTbHKt
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/sbd_1.5.2-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.