<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hello Etienne,</p>
<p>I have started working on the issues you pointed out.</p>
<p>The build failure with gcc12 is fixed (I was very lucky to guess
it, but I am really not sure to understand why it failed in the
first place...).</p>
<p>I've addressed most lintian warnings (not info yet...), but I
struggle a bit with the last one, about package sonames.</p>
<p>I am not sure to understand how I should fix it. I use a semantic
version number for Sight. Usually we try to only break binary
compatibility with major version (19, 20, 21). Lately we also
broke binary compatibility with minor versions, but this should
not happen. Whatever, currently in CMake we define this property
to set the library so version.<br>
</p>
<div style="color: #d4d4d4;background-color: #1e1e1e;font-family: 'Droid Sans Mono', 'monospace', monospace;font-weight: normal;font-size: 14px;line-height: 19px;white-space: pre;"><div><span style="color: #dcdcaa;">set_target_properties</span><span style="color: #d4d4d4;">(</span></div><div><span style="color: #d4d4d4;"> </span><span style="color: #9cdcfe;">${SIGHT_TARGET}</span><span style="color: #d4d4d4;"> </span><span style="color: #4ec9b0;">PROPERTIES</span><span style="color: #d4d4d4;"> </span><span style="color: #4ec9b0;">VERSION</span><span style="color: #d4d4d4;"> </span><span style="color: #569cd6;">${PROJECT_VERSION}</span><span style="color: #d4d4d4;"> </span><span style="color: #4ec9b0;">SOVERSION</span><span style="color: #d4d4d4;"> </span><span style="color: #569cd6;">${PROJECT_VERSION_MAJOR}</span><span style="color: #d4d4d4;">.</span><span style="color: #569cd6;">${PROJECT_VERSION_MINOR}</span></div><div><span style="color: #d4d4d4;"> )</span></div></div>
<div class="moz-signature">
</div>
<div class="moz-signature">So as far I understand with the snippet
given on the lintian warning, it would expects the package to be
named libsight22.0... So two questions:</div>
<div class="moz-signature">
<ol>
<li>We do not have a library libsight.so but many
libsight_name.so. Is this a problem for lintian or would I
need to split into multiple packages ?</li>
<li>Is the solution to rename the package to libsight22.0 ? Or
maybe if I manage to be a bit stricter with development rules,
stick to libsight22 ? If yes, does this mean on every major
upgrade, I need to change the name of the package ? Is it ok
then, to conflict with the previous version to not let the
user install two versions. I ask this because I am really not
sure this is supported currently, and frankly I don't really
see the interest, and I don't have spare time to work on
supporting that.<br>
</li>
</ol>
</div>
<div class="moz-signature">Thank you for your time and advice,</div>
<div class="moz-signature"><br>
</div>
<div class="moz-signature">Kind regards,<br>
</div>
<div class="moz-signature"><br>
<table style="font-family:Calibri,Arial,Helvetica; font-size:13px;
color:#666666" cellspacing="0" cellpadding="0">
<tbody>
<tr valign="top">
<td style="white-space:nowrap; padding-right:20px"> <span style="font-size:18px"><b>Dr. Flavien BRIDAULT</b></span><br>
Director of Software Development<br>
IRCAD France & IRCAD Africa<br>
<br>
<a href="mailto:flavien.bridault-louchez@ircad.fr" style="color:#37D; text-decoration:none">flavien.bridault@ircad.fr</a><br>
Tél. : +33 (0)3 88 119 201<br>
</td>
<td style="background:#DDDDDD; font-size:1px" width="1"> </td>
<td style="padding:0 20px" align="center"> <a target="_blank" href="http://www.ircad.fr/" style="color:#37D; text-decoration:none"> <img src="cid:part1.FiGrU0Hl.sSAk2FTZ@ircad.fr" alt="IRCAD
France" height="50" border="0"><br>
http://www.ircad.fr/<br>
http://www.ircad.africa/ </a> <br>
<br>
Suivez l'IRCAD sur <a target="_blank" href="http://www.facebook.com/pages/IRCAD/193785273990141"><img src="cid:part2.ixRJsYE3.we0qRFSR@ircad.fr" alt="Facebook" title="Facebook" style="vertical-align:middle; margin-bottom:2px" border="0" align="absmiddle"></a> </td>
</tr>
<tr>
<td colspan="4" height="10"> </td>
</tr>
<tr>
<td colspan="4" style="font-size:1px; background:#DDDDDD" height="1"><br>
</td>
</tr>
<tr>
<td colspan="4" style="font-size:11px; padding-top:10px" align="center"><b>IRCAD France</b><br>
Hôpitaux Universitaires - 1, place de l'Hôpital - 67091
Strasbourg Cedex - FRANCE</td>
</tr>
</tbody>
</table>
</div>
<div class="moz-cite-prefix">Le 17/06/2022 à 21:25, Étienne Mollier
a écrit :<br>
</div>
<blockquote type="cite" cite="mid:YqzVRFLOzl0ZGHyP@fusion">
<pre class="moz-quote-pre" wrap="">Hi Flavien,
Flavien Bridault, on 2022-06-14:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">A little "up" in this thread, if someone could have a look at the update of
Sight 21.1 and upload it if it looks ok...
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Thanks for the nudge! Sorry for the delay.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Le 11/05/2022 à 09:01, Flavien Bridault a écrit :
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">I updated Sight to 21.1.1 and updated all patches as usual. It looks
good to me for upload.
Please verify and upload it if you think it is good enough.
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I pulled your changes and ran a build, plus a few tools to help
review. Running `lintian --display-info --pedantic`, please
have a look at the lintian warnings, and see whether they can be
addressed. I notably noticed the following:
W: libsight: duplicate-font-file usr/share/sight/viz_scene3d/Media/fonts/DejaVuSans.ttf also in (fonts-dejavu-core)
W: libsight: unusual-interpreter python [usr/share/sight/viz_scene3d/Media/materials/genDefaultMaterial.py]
Note that there are many more messages. You may override items
if they are not actionable, and document why they are overridden
in the corresponding lintian-overrides file. (Note that I
understood the "elf-error In program headers:" is a lintian bug
on debug symbols packages, so you may just ignore that for the
time being in case it crops up with your lintian version.)
You can also run blhc to check the build log, to make sure
standard Debian build flags are propagated appropriately. At
the moment, it reports that flags propagated through LDFLAGS are
missing in several instances (but maybe there is a good reason
for that, in which case you can ignore-line-regexp and document
why).
If you have the opportunity to do so, you may want to address
the bug #1013036[1]; this is not urgent yet, but will be needed
before debian 12 release. After looking at the build log[2] and
the help page to porting to gcc-12[3], the issue didn't look
exactly obvious to me though.
[1]: <a class="moz-txt-link-freetext" href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1013036">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1013036</a>
[2]: <a class="moz-txt-link-freetext" href="http://qa-logs.debian.net/2022/06/09/gcc12/sight_21.0.0-4_unstable_gcc12.log">http://qa-logs.debian.net/2022/06/09/gcc12/sight_21.0.0-4_unstable_gcc12.log</a>
[3]: <a class="moz-txt-link-freetext" href="https://gcc.gnu.org/gcc-12/porting_to.html">https://gcc.gnu.org/gcc-12/porting_to.html</a>
In general, you may want to have a look at the package tracker
to have a summary of some of the different issues[4] in the
existing unstable version you might want to address.
[4]: <a class="moz-txt-link-freetext" href="https://tracker.debian.org/pkg/sight">https://tracker.debian.org/pkg/sight</a>
The package looks otherwise in good shape to me, and I would be
happy to upload (or happy to be beaten at uploading by someone
else) once you address the warnings I pointed to and ready the
debian/changelog for upload to unstable instead of UNRELEASED.
Thank you for your contributions!
Have a nice day, :)
</pre>
</blockquote>
</body>
</html>