<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
Hi Andrius, Thorsten,
<br>
<blockquote type="cite">
<br>
Thank you for such a speedy review. We will resolve and reupload.
<br>
</blockquote>
<br>
I concur. And I think I resolved the issues. Andrius may try to
upload again.<br>
<br>
About that regex issue, see
<a class="moz-txt-link-freetext" href="https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86164">https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86164</a><br>
<br>
It is a long standing issue and it is a bit frustrating this isn't
fixed yet. Using the newest header-only boost regex was a very nice
solution avoiding a dependency on runtime libraries. I understand
this is not an issue with Debian packages, but it is a very big
issue with code distributed directly to the average user of my
software.<br>
<br>
regards, -maarten<br>
<br>
<blockquote type="cite">
<br>
On 2022-11-14 21:00, Thorsten Alteholz wrote:
<br>
<blockquote type="cite" style="color: #007cff;">please also
mention at least libcifpp-5.0.3/include/cif++/gzio.hpp in your
debian/copyright.
<br>
<br>
While you are at it, please document in some README, why you
need to embed a copy of the boost regex header files.
<br>
</blockquote>
<br>
Maarten, do we need these files for Debian build? CMakeLists.txt
say that boost regex headers are used to avoid crashing std::regex
implementation (shouldn't this be fixed in std::regex upstream?).
Even if so, maybe we can use Debian-provided boost regex headers
and unembed them from libcifpp?
<br>
<br>
<blockquote type="cite" style="color: #007cff;">Is there a reason
why you remove the data update cronjob only when purging the
package? Shouldn't that be done when removing it as well?
<br>
</blockquote>
<br>
Removing cronjob at removal makes sense to me as well. IMO, purge
should only remove the configuration file.
<br>
<br>
Best,
<br>
Andrius
</blockquote>
</body>
</html>