<html><head><style>pre,code,address {
margin: 0px;
}
h1,h2,h3,h4,h5,h6 {
margin-top: 0.2em;
margin-bottom: 0.2em;
}
ol,ul {
margin-top: 0em;
margin-bottom: 0em;
}
blockquote {
margin-top: 0em;
margin-bottom: 0em;
}
</style></head><body><div>Le samedi 01 mars 2025 à 18:25 +0100, Étienne Mollier a écrit :</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Hi Flavien, Hi Andreas,<br></div><div><br></div></blockquote><div>Hi Etienne,</div><div><br></div><div>Thank you for your quick answer. I respond to you in the text below.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Flavien BRIDAULT, on 2025-03-01:<br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>I updated "Sight" package to 25.0.0, and updated all patches. It looks<br></div><div>good to me for an upload.<br></div></blockquote><div><br></div><div>I took a look at the changes in Salsa. The package is overall<br></div><div>in good shape. I have just spotted the following issues rather<br></div><div>easy to fix:<br></div><div><br></div><div> * The copyright year may be bumped to 2025 upstream, same for<br></div><div> the packaging directory.<br></div></blockquote><div>Done.</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div></blockquote><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div> * The ubuntu1 version suffix is not needed for debian. :)<br></div></blockquote><div>Omg, I swear I removed it al least three times but it always comes back. :) My bad, I fixed it.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div><div> * Lintian complains about NMU upload, this looks to be caused<br></div><div> by mismatched email address between the d/changelog and the<br></div><div> d/control. Please can you update one or both to your<br></div><div> preferred contact address?<br></div></blockquote><div>Fixed in the changelog.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div><div>Apart from that, there is the duplicate Roboto font face which<br></div><div>may gain being deduplicated with the packaged font, but I also<br></div><div>concur it's a little more involved and is probably around for a<br></div><div>while. If this can be sorted, that would facilitate reading the<br></div><div>lintian warnings output.<br></div></blockquote><div>Indeed, this surprises me because I had the intent to remove them in a previous commit (203e521c). The files are mentioned in the not-installed but are included in the regex in libsight.install, so I assume I made a mistake. I had to introduce a new patch but this should be fine now, thank your for spotting it. I will forward the changes upstream.</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div><div>Thanks Flavien for taking the time to prepare a package of this<br></div><div>magnitude! I'm okay with proceeding to an upload after the<br></div><div>three points are addressed. Maybe Andreas will have other<br></div><div>observations if he took some time to have a look.<br></div><div><br></div></blockquote><div>You are welcome. Thanks again for your feedback and tell me if that's fine now or if you request any other changes.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Have a nice day, :)<br></div></blockquote><div><br></div><div><span></span></div></body></html>