[From nobody Sat Oct 17 20:53:05 2026
Received: (at submit) by bugs.debian.org; 15 Feb 2025 10:06:49 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
 (2021-04-09) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-111.4 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,
 MD5_SHA1_SUM,SPF_HELO_NONE,SPF_NONE,UNPARSEABLE_RELAY,
 USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,XMAILER_REPORTBUG
 autolearn=ham autolearn_force=no
 version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 66; hammy, 150; neutral, 86; spammy,
 0. spammytokens:
 hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
 0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
 0.000-+--H*RT:311, 0.000-+--H*RT:108
Return-path: &lt;aurel32@debian.org&gt;
Received: from stravinsky.debian.org ([2001:41b8:202:deb::311:108]:58476)
 from C=NA, ST=NA, L=Ankh Morpork, O=Debian SMTP, OU=Debian SMTP CA,
 CN=stravinsky.debian.org, EMAIL=hostmaster@stravinsky.debian.org (verified)
 by buxtehude.debian.org with esmtps
 (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
 (Exim 4.94.2) (envelope-from &lt;aurel32@debian.org&gt;)
 id 1tjF4T-001sFq-IX
 for submit@bugs.debian.org; Sat, 15 Feb 2025 10:06:49 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; 
 s=smtpauto.stravinsky;
 h=X-Debian-User:Date:Message-ID:Subject:To:From:
 Content-Transfer-Encoding:MIME-Version:Content-Type:Reply-To:Cc:Content-ID:
 Content-Description:In-Reply-To:References;
 bh=GTTACg6EpsNhpqE7XgY9euj4YrcHmDnlurZ0vFKtFe0=; b=WiJfONabPiU1EHDELpUMdz7cyd
 WE4hZCVPw5aebcv6Wx/hsHdFLvO07ca5QsDOoCJf6jgUhTs2KS3gHoVm8ZcD72LZhDGSrjMnRM+uV
 Nnu/dJXmaWBg07TPuE3GZjy3uyEknegsObihOCA/6sNqWoDgayqpxESgzsQzqvZYXP+XeegRt6TCu
 o6g5w/X697RSO3QMoNh88j8pkwV4bGCy5Y0bQ7bTrTQ5vr7OzzsNkZqZr+AmDcTPzbS0WpCva8qlU
 +DdW1s/UnNtOzvrmQ21X6AiM3CqkfeJGUtmy5cKwXd8PqYLweMdPiXY33jM/9/wKYBmN19977W79G
 0tac1FZw==;
Received: from authenticated user by stravinsky.debian.org with esmtpsa
 (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
 (Exim 4.94.2) (envelope-from &lt;aurel32@debian.org&gt;)
 id 1tjF4Q-00AFkT-Sm
 for submit@bugs.debian.org; Sat, 15 Feb 2025 10:06:47 +0000
Received: from [2a01:e34:ec5d:a741:1ee1:92ff:feb4:5ec0] (helo=ohm.rr44.fr)
 by hall.aurel32.net with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from &lt;aurel32@debian.org&gt;) id 1tjF4P-001uD6-1v;
 Sat, 15 Feb 2025 11:06:45 +0100
Content-Type: text/plain; charset=&quot;us-ascii&quot;
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Aurelien Jarno &lt;aurel32@debian.org&gt;
To: Debian Bug Tracking System &lt;submit@bugs.debian.org&gt;
Subject: bart-cuda: autopkgtest failure with glibc 2.41 due to increased
 accuracy of atan2f function
Message-ID: &lt;173961400400.2494731.2717779408295892215.reportbug@ohm.local&gt;
X-Mailer: reportbug 13.0.2
Date: Sat, 15 Feb 2025 11:06:44 +0100
X-Debian-User: aurel32
Delivered-To: submit@bugs.debian.org

Source: bart-cuda
Version: 0.8.00-2
Severity: important
Tags: ftbfs patch
Justification: fails to build from source
X-Debbugs-Cc: debian-glibc@lists.debian.org
User: debian-glibc@lists.debian.org
Usertags: glibc2.41

Dear maintainer,

The bart-cuda autopkgtest fails when run against glibc 2.41, which is
currently in experiemntal. It fails with [1]:

| 3772s touch tests/test-traj-custom
| 3772s set -e ; mkdir /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp/tests/tmp/$$/ ; cd /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp/tests/tmp/$$/			;\
| 3772s /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp//traj -R0. -r -y360 -D t0.ra 				;\
| 3772s /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp//phantom -k -t t0.ra k0.ra 				;\
| 3772s /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp//traj -R30. -r -y360 -D t30.ra			;\
| 3772s /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp//phantom -k -t t30.ra k30.ra 				;\
| 3772s /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp//estshift 4 k0.ra k30.ra | grep &quot;30.00000&quot; 		;\
| 3772s rm *.ra ; cd .. ; rmdir /tmp/autopkgtest-lxc.oedkyjwg/downtmp/autopkgtest_tmp/tests/tmp/$$/
| 3774s make: *** [tests/traj.mk:53: tests/test-traj-rot] Error 1

Investigation shows that this is due to improved accuracy of the atan2f
function in glibc 2.41. In details bart-cuda computes
atan2f(0x1.166202p-4, 0x1.e22c5ap-4) and it expects it to be 30.00000
when converted from radian to degrees, ie it expects the atan2f function
to return 0x1.0c1524p-1.

With glibc 2.41, the atan2f function has been improved [2] and now
returns instead 0x1.0c1522p-1 which is closer to the real value than
0x1.0c1524p-1.  This corresponds to 29.999998 when converted to degrees.
The patch below fixes the issue by accepting both values.

Regards
Aurelien

--- bart-cuda-0.8.00.orig/tests/traj.mk
+++ bart-cuda-0.8.00/tests/traj.mk
@@ -55,7 +55,7 @@ tests/test-traj-rot: traj phantom estshi
 	$(TOOLDIR)/phantom -k -t t0.ra k0.ra 				;\
 	$(TOOLDIR)/traj -R30. -r -y360 -D t30.ra			;\
 	$(TOOLDIR)/phantom -k -t t30.ra k30.ra 				;\
-	$(TOOLDIR)/estshift 4 k0.ra k30.ra | grep &quot;30.00000&quot; 		;\
+	$(TOOLDIR)/estshift 4 k0.ra k30.ra | grep &quot;30.00000\|29.999998&quot;	;\
 	rm *.ra ; cd .. ; rmdir $(TESTS_TMP)
 	touch $@

[1] https://ci.debian.net/data/autopkgtest/unstable/amd64/b/bart-cuda/57639405/log.gz
[2] https://sourceware.org/git/?p=glibc.git;a=commit;h=6f9bacf36b20b1a87fa4ec24c9d67c47985fbc8b
]