[Debian-on-mobile-maintainers] Bug#1003476: Bug#1003476: libomemo cross misbuilds

[Evangelos Ribeiro Tzaras]

Hi,

On Mon, 2022-01-10 at 21:01 +0100, Helmut Grohne wrote:
> Source: libomemo
> Version: 0.7.0-1
> Tags: patch
> User: debian-cross at lists.debian.org
> Usertags: ftcbfs
> 
> When cross building libomemo it uses the build architecture multiarch
> dir, but it should be using the host architecture one.

This confused me for a moment (in fact I wondered if it shouldn't be
the other way around), because I naively misunderstood the meaning of
"build" (as in the architecture for which to build) and "host" (as in
the host I'm building on), but after looking it up [1] it makes a lot
more sense ;)

>  It's because it
> derives it from gcc -print-multiarch. In order to fix that one needs
> to
> use $(CC) and pass CC to make install. Please consider applying the
> attached patch.

Thanks a lot for providing a patch!

Out of curiosity: That patch works because in a cross compilation CC
will f.e. be aarch64-linux-gnu-gcc because that is set via the included
/usr/share/dpkg/buildtools.mk, right?

Initially I contemplated including /usr/share/dpkg/architecture.mk and
somehow using DEB_TARGET_GNU_TYPE, but your patch seems much cleaner,
so thanks a lot!

Since this actually issue came up [2] some time ago upstream and the 
$(CC) bit could go there, do you want to submit this part of the patch
or should I do this (preserving your authorship of course!)?

[1] http://gcc.gnu.org/onlinedocs/gccint/Configure-Terms.html
[2] https://github.com/gkdr/libomemo/issues/6#issuecomment-849190527

Cheers,
-- 
Evangelos
PGP: B938 6554 B7DD 266B CB8E 29A9 90F0 C9B1 8A6B 4A19