[Debian-on-mobile-maintainers] Bug#1050762: feedbackd-device-themes: Users are not informed about existing tools from the feedbackd package

[Boud Roukema]

hi Guido,

On Tue, 29 Aug 2023, Guido Günther wrote:

> On Tue, Aug 29, 2023 at 02:12:36AM +0200, Boud Roukema wrote:
>> I discovered from browsing sources and git histories that the debian
>> 'feedbackd' package automatically installs several user-level programs
>> that the user should be informed about:
>>
>> $ dpkg -L feedbackd | grep /usr/bin
>>
>> /usr/bin
>> /usr/bin/fbcli
>> /usr/bin/fbd-theme-validate
>
> Users are informed via the manpages.

Currently in Debian/trixie:

- 'man feedbackd' gives 'See also fbcli(1)', so yes, there's a footnote,
but it could be made more prominent
- 'man fbcli' says nothing about fbd-theme-validate

> I've added a feedback-themes manpage upstream so apropos and other
> tools make it easier to find.

Thanks! I assume you mean your MR listed below:
https://source.puri.sm/Librem5/feedbackd/-/merge_requests/112

At the Debian level, the only thing that seems to be missing in MR 112
is crosslinks to and from the 'feedbackd-device-themes' package,
and a clarification if and how the user can (or cannot) use both
a device-specific theme and a custom theme 
(in 'src/fbd-theme-expander.c' I see the line
   /* Device specific lookup only for default theme */).

I assume that this could also better be handled at the upstream level.
In fact, this particular bug #1050762 is for feedbackd-device-themes.


>> PROPOSAL:
>
> Thanks for proposing changes but I'd rather not duplicate documentation
> as I don't want to maintain it in different places. There's nothing

Sure, no problem. :)

> Debian specific here so it should be part of the upstream docs and
> trickle into Debian.
>
> If you find anything missing please propose an MR there but note
>
>   https://source.puri.sm/Librem5/feedbackd/-/merge_requests/112
>
> [..snip..]

For 'feedbackd-device-themes', I'm happy to wait until things trickle
down to Debian/Mobian and then see if something's missing.

Regarding MRs at source.puri.sm, I followed the instructions at
https://source.puri.sm/Purism/public-announcement/-/wikis/home
for getting 'external access', but I didn't receive an email for confirmation.
I posted a question at #community-librem-one:talk.puri.sm, but
that channel seems to be inactive; #community-general:talk.puri.sm
seems to be invitation-only. Should I email  source puri.sm ? It's
about the only official instruction I haven't tried yet.

>> To see the effects of your custom.json file, you will need to restart
>> the running "feedbackd" daemon, e.g. "killall feedbackd" and then
>> close and reopen a gui such as chatty that automatically restarts
>> "feedbackd". Then (or before you switch) you can check individual
>> effects:
>
> Just as a remark:
>
> There's neither a need to kill feedbackd as it can reload it's config on
> SIGHUP nor do you need to restart apps.

I'll try that - thanks.

Cheers
Boud