[Debian-on-mobile-maintainers] Bug#1032914: phog: ships /etc/pam.d/greetd

[Arnaud Ferraris]

Hi,

Le 22/03/2023 à 17:58, Marc Dequènes (duck) a écrit :
> Quack,
>
> Honestly when I read the title I really wondered how phog could have 
> ended-up shipping this file. I forgot it initially, was asked about it 
> and added it quickly, so it's not like I would have rejected the idea.

Well yes, it was only supposed to be transitional waiting for 
https://lists.sr.ht/~kennylevinsen/greetd/patches/36264 to land 
upstream, but I went a bit too optimistic on that one, my bad...

> Anyway, back to the patch itself. First I wonder if it's useful to 
> ship the second PAM config since in the code 
> (greetd/src/server.rs#211) it simply use the base greetd PAM 
> configuration as a fallback; this is not a blocker though.

The greeter PAM config drops the gnome-keyring/kwallet bits in order to 
be a bit lighter at runtime (those lines cause at least 
"gnome-keyring-daemon" to be started for user "_greetd", which is 
basically useless as it's a system user with no actual use of a 
keyring). Therefore I feel it's best to keep both config separate, but 
I'd be fine with a single config if you prefer it that way.

> Then I would prefer if the changelog entries were shipped with the 
> corresponding changes and not in a lump afterwards. Also the "debian:" 
> and "d/*:" prefixes are not the style I use. Maybe I'm missing why 
> some people still use it but with the VCS taking care of remembering 
> which files have been changed I don't feel the need to add this 
> anymore and it's not very non-DD friendly. I like your comments to 
> clearly explain the rationale.

Thanks for the comments, I'm attaching the updated patches.

Cheers,
Arnaud

>
> Regards.
> \_o<
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-PAM-configuration-s.patch
Type: text/x-patch
Size: 4301 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-on-mobile-maintainers/attachments/20230324/e2bb67f6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-Breaks-Replaces-relationships-on-older-phog.patch
Type: text/x-patch
Size: 1899 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-on-mobile-maintainers/attachments/20230324/e2bb67f6/attachment-0001.bin>