[Debian-on-mobile-maintainers] Bug#1050762: two more minor fixes in your upstream fixes

Guido Günther agx at sigxcpu.org
Fri Sep 1 12:13:39 BST 2023


Hi,
(put the bug in cc: so we have a all the bits together)

On Thu, Aug 31, 2023 at 11:09:02PM +0200, Boud Roukema wrote:
> hi Guido,
> 
> I agree with closing #1050762. But upstream I still see two minor fixes
> needed (unless I misunderstand something):
> 
> https://source.puri.sm/Librem5/feedbackd/-/blob/main/doc/fbd-theme-validate.rst
> - 'See also' is missing  fbd-theme-validate(1)

I assume you mean `missing `feedback-themes`, I've added that.

> https://source.puri.sm/Librem5/feedbackd/-/blob/main/doc/feedbackd.rst
> - 'See also' has a double copy of 'feedback-themes(5)'

Dropped that, thanks!

> https://source.puri.sm/Librem5/feedbackd/-/blob/main/doc/feedback-themes.rst
> https://source.puri.sm/Librem5/feedbackd/-/blob/main/doc/fbcli.rst
> - these two both look correct :)
> 
> The other bug, #1050601, still looks open to me. At least the upstream main

That's why I didn't close it yet. The README isn't suitable to install
though as half of the information isn't relevant on the installed
system. The corresponding bits need to move to the manpages (which is
also an opportunity to disentangle those).

Cheers,
 -- Guido

> documentation files such as "README.md" and "NEWS" should be installed into
> the debian /usr/shared/doc/feedbackd/  directory. That's not duplication - it
> allows someone without internet access to access more documentation than the
> man pages. README.md will generally give more info than a man page.
> Anyway, we can discuss that further on that bug thread, which differs from
> this one.
> 
> Cheers
> Boud
> 



More information about the Debian-on-mobile-maintainers mailing list