<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 12/14/21 3:54 PM, Jerome BENOIT
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:98acc4aa-2743-fe69-cf42-d48bf1e282c5@rezozer.net">Hi,
<br>
<br>
On 14/12/2021 16:40, Tobias Hansen wrote:
<br>
<blockquote type="cite">On 12/14/21 12:08 PM, Dima Pasechnik
wrote:
<br>
<blockquote type="cite">On Tue, Dec 14, 2021 at 11:23 AM Jerome
BENOIT <a class="moz-txt-link-rfc2396E" href="mailto:calculus@rezozer.net"><calculus@rezozer.net></a> wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
On 14/12/2021 11:55, Dima Pasechnik wrote:
<br>
<blockquote type="cite">
<br>
On Tue, 14 Dec 2021, 10:40 Torrance, Douglas,
<<a class="moz-txt-link-abbreviated" href="mailto:dtorrance@piedmont.edu">dtorrance@piedmont.edu</a>
<a class="moz-txt-link-rfc2396E" href="mailto:dtorrance@piedmont.edu"><mailto:dtorrance@piedmont.edu></a>> wrote:
<br>
<br>
The Linbox team just released new versions of Givaro
[1] and FFLAS-FFPACK
<br>
[2]. Is it okay to upload these to unstable, or
would that be disruptive to
<br>
Sage? It looks like some patches may be necessary --
see [3]. Note that the
<br>
release candidates have been in experimental for a
little while already.
<br>
<br>
<br>
apparently all you need is a Singular patch, to remedy a
header conflict:
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/Singular/Singular/commit/18bb792edcc6d3f65af0111f93ed61118123ffd1">https://github.com/Singular/Singular/commit/18bb792edcc6d3f65af0111f93ed61118123ffd1</a>
<a class="moz-txt-link-rfc2396E" href="https://github.com/Singular/Singular/commit/18bb792edcc6d3f65af0111f93ed61118123ffd1"><https://github.com/Singular/Singular/commit/18bb792edcc6d3f65af0111f93ed61118123ffd1></a>
<br>
</blockquote>
This patch seems to be purely aesthetic: some #define are
translated.
<br>
</blockquote>
It should move
<br>
<br>
#define IntegerDomain 1
<br>
<br>
into "private" space, and is meant to be processed with
`factory/bin/makeheader`
<br>
I'd say such files should not be named `*.h`, but rather
something
<br>
like `*.h.in`.
<br>
<br>
Dima
<br>
<br>
</blockquote>
If Jerome wants to apply this patch I would say you could update
these packages before I upload sagemath 9.4.
<br>
<br>
The opposite order would also work, then sagemath just has to be
rebuilt.
<br>
</blockquote>
<br>
My understanding is that this patch is aesthetic, namely
clueless.
<br>
Unless I miss something.
<br>
<br>
</blockquote>
<p>Hi,</p>
<p>as Dima said, it changes the order of things so that<br>
</p>
<p><span class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker=" ">#<span class="pl-k">define</span> <span
class="pl-en">IntegerDomain</span> <span class="pl-c1">1</span></span></p>
<p><span class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker=" "><span class="pl-c1">is moved into the
private section.</span></span></p>
<p><br>
<span class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker=" "><span class="pl-c1"><span
class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker="+"><span class="pl-c"><span class="pl-c">/*</span>BEGINPUBLIC<span
class="pl-c">*/ is not just a comment as it is replaced
by something else by </span></span></span></span></span><br>
<span class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker=" "><span class="pl-c1"><span
class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker="+"><span class="pl-c"><span class="pl-c">factory/bin/makeheader.</span></span></span></span></span></p>
<p><span class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker=" "><span class="pl-c1"><span
class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker="+"><span class="pl-c"><span class="pl-c">Best,</span></span></span></span></span></p>
<p><span class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker=" "><span class="pl-c1"><span
class="blob-code-inner blob-code-marker js-code-nav-pass "
data-code-marker="+"><span class="pl-c"><span class="pl-c">Tobias<br>
</span></span></span></span></span></p>
<br>
</body>
</html>