<div dir="auto">Hello,<div dir="auto"><br></div><div dir="auto"> I am really sorry about the delay, I hoped our community expert on the Qx drivers would recommend the best course of action, but he did not reply yet.</div><div dir="auto"><br></div><div dir="auto"> To me it currently seems that this Pull request: <a href="https://github.com/networkupstools/nut/pull/638/files">https://github.com/networkupstools/nut/pull/638/files</a> represents the modernly desirable addition of a USB protocol subdriver (in nutdrv_qx.c/.h) and the vendor protocol nuances subdriver (in separate files).</div><div dir="auto"><br></div><div dir="auto"> Sadly, according to comment trail, that particular Pull request changed a bit of logic in existing functions (around langid_fix and enabling a hunnox patch, most prominently) and there were concerns if it is not breaking anything for other devices that work currently. It would be beneficial if people running nutdrv_qx today could build that branch and confirm into PR comments that the updated driver does work well or does break something after all.</div><br><div dir="auto"> So I think the new ablerex subdriver should carefully take a similar path. Nutdrv_qx modular code did grow as a refactoring and merge of earlier drivers including blazer, so your original code contribution should be easily portable into the new layout.</div><div dir="auto"><br></div><div dir="auto">Thank you very much and really sorry it took longer that I'd expect,</div><div dir="auto">Jim Klimov</div><div dir="auto"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 29, 2021, 13:16 Johnson-shen <<a href="mailto:johnson-shen@ablerex.com.tw">johnson-shen@ablerex.com.tw</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>Dear Sir,</div>
<div><br>
</div>
<div>Thank you for your reply.<br>
</div>
<div><br>
</div>
<div>I can not sure what you mean.<br>
</div>
<div><br>
</div>
<div>May I confirm with you again about it?<br>
</div>
<div><br>
</div>
<div>You did not recommend that extend the
new function from blazer_usb.c for Ablerex UPS.<br>
</div>
<div><br>
</div>
<div>You suggest that separate the Ablerex
function into a new driver(.c or .h) independently to avoid vendor
nuances.<br>
</div>
<div><br>
</div>
<div>Until we follow the above rule to
modify, It will be upload and merge the driver.<br>
</div>
<div><br>
</div>
<div>Is it right?<br>
</div>
<div><br>
</div>
<div>Please kindly provide more information
or explain to us, if I got you wrong.<br>
</div>
<div><br>
</div>
<div>Please kindly provide the example for a
new structure to us, I think will help to modify it for reference,
if it is right.<br>
</div>
<div><br>
</div>
<div>Regards!</div>
<div>Johnson</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Jim Klimov 於 3/24/2021 6:26 PM 寫道:<br>
</div>
<blockquote type="cite">
<div dir="auto">Hello,
<div dir="auto"><br>
</div>
<div dir="auto">Yes, in fact there were two things.</div>
<div dir="auto"><br>
</div>
<div dir="auto">One was that a week ago I posted some
documentation updates into your PR (e.g. for acknowledgements)
and asked you to confirm they sit well with you, and hoped
that's it.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Unfortunately, I was now reminded that extending
the blazer_usb driver was not a good approach - it was
(poorly, fixing that) documented as heading to obsoletion and
eventual removal from codebase. Various drivers for Qx
protocols were aggregated in drivers/nutdrv_qx*.{c,h} as a
common core and clean separate sources for vendor nuances.</div>
<div dir="auto"><br>
</div>
<div dir="auto">In order for us to maintain support for your
device in the long run, and not lose it when old redundant
drivers do get dropped, your code contribution should be
relocated to this newer structure, and importantly - re-tested
with your hardware we do not have access to. I hope Daniele
(CC'ed) can clarify this better if you would need assistance.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Sorry about not noticing this earlier,</div>
<div dir="auto">Jim Klimov</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Mar 24, 2021, 03:58
Johnson-shen <<a href="mailto:johnson-shen@ablerex.com.tw" target="_blank" rel="noreferrer">johnson-shen@ablerex.com.tw</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>Dear Sir,</div>
<br>
The status of the project is waiting for the other managers
to verify and confirm? <br>
<p>Please advise me if you have any support for this
project.</p>
<p><br>
</p>
<p>Regards!</p>
<p>Johnson</p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<div>Jim Klimov 於 3/18/2021 8:07 PM 寫道:<br>
</div>
<blockquote type="cite">
<div dir="auto">Hello, thanks for the driver update and
sorry that I had to be reminded of the PR by mailing
list. I reviewed it last week and added a few points on
documentation. Can you please check those, that I did
not mistake something, and I think it is good to merge.
Thanks again!
<div dir="auto"><br>
</div>
<div dir="auto">Jim Klimov</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Mar 18, 2021,
11:33 Johnson-shen <<a href="mailto:johnson-shen@ablerex.com.tw" rel="noreferrer noreferrer noreferrer" target="_blank">johnson-shen@ablerex.com.tw</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>Dear Wolfy,</div>
<div><br>
</div>
Please advise me, if you need more information about
the new driver.<br>
Also please kindly update the status of the new
driver for us.
<div><br>
</div>
<div>Regards!</div>
<div>Johnson</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Johnson-shen 於 3/10/2021 6:24 PM 寫道:<br>
</div>
<blockquote type="cite">
<div>Dear Wolfy,</div>
<div><br>
</div>
<div>Please refer to the below table for the whole
support list of the UPS Model of the new driver.</div>
<div><br>
</div>
<div><img alt=""></div>
<div><br>
</div>
<div><br>
</div>
<div>Please kindly advise me if you have any
questions.</div>
<div><br>
</div>
<div>Regards!</div>
<div>Johnson</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Johnson-shen 於 3/10/2021 9:43 AM 寫道:<br>
</div>
<blockquote type="cite">
<div>Dear Wolfy,</div>
<div><br>
</div>
Thank you for the reply to emails quickly, the
DK+ is our customer model name for ODM.<br>
<br>
We will provide the whole support list of UPS
Model of the driver to you tomorrow.<br>
<p><br>
</p>
<p><br>
</p>
<p>Regards!</p>
<p>Johnson</p>
<p><br>
</p>
<div><br>
</div>
<div> <br>
</div>
<div> <br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Manuel Wolfshant 於 3/9/2021 7:11 PM 寫道:<br>
</div>
<blockquote type="cite">
<div>On 3/9/21 8:37 AM, John wrote:<br>
</div>
<blockquote type="cite">
<div>
<p class="MsoNormal"><span lang="EN-US">Hi,</span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">I'm
engineer from Ablere Electronics Co.,
Ltd. (<a href="http://www.ablerex.com.tw/" rel="noreferrer noreferrer
noreferrer noreferrer" target="_blank">http://www.ablerex.com.tw/</a>).</span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">I
pull request to networkupstools/nut
that Add support for Ablerex Dk+ #979.</span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
</div>
</blockquote>
<br>
<p>long time user of an MS3000RT here. where
is the DK+ described? I cannot find it on
your web site or via google.<br>
</p>
<p><br>
</p>
<p>wolfy<br>
</p>
</blockquote>
<p><br>
</p>
<pre cols="72">--
盈正豫順電子股份有限公司
Ablerex Electronics Co., Ltd.
研發部 / 沈南村
E-mail: <a href="mailto:Johnson-shen@ablerex.com.tw" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">Johnson-shen@ablerex.com.tw</a>
Tel: 886-7-397-8640 Ext: 894
Fax: 886-7-3978641
807-66高雄市三民區水源路157號
No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
(R.O.C.)</pre>
</blockquote>
<p><br>
</p>
<pre cols="72">--
盈正豫順電子股份有限公司
Ablerex Electronics Co., Ltd.
研發部 / 沈南村
E-mail: <a href="mailto:Johnson-shen@ablerex.com.tw" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">Johnson-shen@ablerex.com.tw</a>
Tel: 886-7-397-8640 Ext: 894
Fax: 886-7-3978641
807-66高雄市三民區水源路157號
No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
(R.O.C.)</pre>
</blockquote>
<p><br>
</p>
<pre cols="72">--
盈正豫順電子股份有限公司
Ablerex Electronics Co., Ltd.
研發部 / 沈南村
E-mail: <a href="mailto:Johnson-shen@ablerex.com.tw" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">Johnson-shen@ablerex.com.tw</a>
Tel: 886-7-397-8640 Ext: 894
Fax: 886-7-3978641
807-66高雄市三民區水源路157號
No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
(R.O.C.)</pre>
</div>
_______________________________________________<br>
Nut-upsdev mailing list<br>
<a href="mailto:Nut-upsdev@alioth-lists.debian.net" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">Nut-upsdev@alioth-lists.debian.net</a><br>
<a href="https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev</a><br>
</blockquote>
</div>
</blockquote>
<p><br>
</p>
<pre cols="72">--
盈正豫順電子股份有限公司
Ablerex Electronics Co., Ltd.
研發部 / 沈南村
E-mail: <a href="mailto:Johnson-shen@ablerex.com.tw" rel="noreferrer noreferrer" target="_blank">Johnson-shen@ablerex.com.tw</a>
Tel: 886-7-397-8640 Ext: 894
Fax: 886-7-3978641
807-66高雄市三民區水源路157號
No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
(R.O.C.)</pre>
</div>
</blockquote>
</div>
</blockquote>
<p><br>
</p>
<pre cols="72">--
盈正豫順電子股份有限公司
Ablerex Electronics Co., Ltd.
研發部 / 沈南村
E-mail: <a href="mailto:Johnson-shen@ablerex.com.tw" target="_blank" rel="noreferrer">Johnson-shen@ablerex.com.tw</a>
Tel: 886-7-397-8640 Ext: 894
Fax: 886-7-3978641
807-66高雄市三民區水源路157號
No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
(R.O.C.)</pre>
</div>
</blockquote></div>