<div dir="ltr"><div>> ...if syslog one gets the program name. So upsdebugx should therefore 1) not have the driver name...</div><div><br></div><div>>
I was confused; syslog on my system is printing the program name.<span class="gmail-im"><br></span></div><div><span class="gmail-im"><br></span></div><div><span class="gmail-im">Yes, just to clarify: syslog (protocol and common implementations) normally add tags regarding whom it received a message from.<br></span></div><div><span class="gmail-im">There may of course be some code calling upsdebugx and its format string stating the program name (so in syslog you would see it twice), and generally that feels like overkill :)</span></div><div><span class="gmail-im"><br></span></div><div><span class="gmail-im">Jim<br></span></div><div><span class="gmail-im"><br></span>
</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jan 15, 2023 at 6:46 PM Greg Troxel <<a href="mailto:gdt@lexort.com">gdt@lexort.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Jim Klimov <<a href="mailto:jimklimov%2Bnut@gmail.com" target="_blank">jimklimov+nut@gmail.com</a>> writes:<br>
<br>
> I don't think there is any particular strategy, at least not one I'd know<br>
> of either :) So it is mostly ad-hoc, to keep smaller verbosity numbers<br>
> reasonably quiet, and sufficient info to see the logic progression at a<br>
> given debug level (e.g. if major milestones of a routine are logged at<br>
> level N, further traces like "I saw value X here" would be N+1 or more).<br>
> De-facto verbosities fizzle out at 6, but generally it is an int value,<br>
> so...<br>
<br>
Sounds good - what I wrote down as a plan for bestfortress very much<br>
matches that, 1 to 5 where 5 is if you want to see every IO byte.<br>
<br>
> Regarding syslog/stdout/stderr, the upsdebugx*() methods are defined here<br>
> and near:<br>
> <a href="https://github.com/networkupstools/nut/blob/ad70749f243527e774c3f03a08228430143396e9/common/common.c#L1205" rel="noreferrer" target="_blank">https://github.com/networkupstools/nut/blob/ad70749f243527e774c3f03a08228430143396e9/common/common.c#L1205</a><br>
> and end up calling vupslog() at which can report to stderr (not stdout)<br>
> and/or syslog, based on settings - see around<br>
> <a href="https://github.com/networkupstools/nut/blob/ad70749f243527e774c3f03a08228430143396e9/common/common.c#L1011" rel="noreferrer" target="_blank">https://github.com/networkupstools/nut/blob/ad70749f243527e774c3f03a08228430143396e9/common/common.c#L1011</a>.<br>
> The UPSLOG_STDERR bit is set by default, but cleared in the background()<br>
> method, along with raising the UPSLOG_SYSLOG bit. By default enabled debug<br>
> means staying foreground, so the bits are not changed. However "recently"<br>
> the explicit -F/-B flags were added to manipulate fore-/back-grounding<br>
> independently of debug (default behavior remains as it was).<br>
<br>
ack, makes sense.<br>
<br>
> Note that daemons started under service management frameworks like SMF or<br>
> systemd can remain in "foreground" mode (with backgrounding handled by<br>
> framework forking itself), so continue logging to stderr with messages<br>
> landing into systemd journal or SMF service-instance log file.<br>
<br>
ok - netbsd doesn't do that (expecting things to daemonize and use<br>
syslog), but good to know.<br>
<br>
> A few programs are more explicit about this, e.g.:<br>
> ````<br>
> :; git grep -n syslogbit_set<br>
> common/common.c:130:void syslogbit_set(void)<br>
> include/common.h:234:void syslogbit_set(void);<br>
><br>
> clients/upssched.c:1341: syslogbit_set();<br>
> drivers/main.c:1052: syslogbit_set();<br>
> server/upsd.c:1827: syslogbit_set();<br>
> ````<br>
<br>
I did find that in drivers/main.c.<br>
<br>
> So upsdebugx should therefore 1) not have the driver name and 2) should<br>
> have a function, for things that aren't clearly locatable. Correct?<br>
><br>
> 1) I don't think it prints a driver name (at least not by itself - maybe<br>
> some drivers or other programs pass format strings which hardcode such<br>
> stuff).<br>
<br>
I was confused; syslog on my system is printing the program name.<br>
<br>
> 2) a common incantation is `upsdebugx(NUM, "%s: some text", __func__);` to<br>
> take advantage of modern compilers providing the __func__ macro.<br>
> Technically also __FILE__ and __LINE__ may be used. Neither is guaranteed<br>
> across the portability board however, but that is likely to only bite very<br>
> old systems nowadays. The `configure` script tries some fallbacks for<br>
> __func__ but not for others.<br>
<br>
Thanks - I may try that, but I think I'm trying to write debug<br>
statements that are sort of human readable without code refs and also<br>
easily findable in the code.<br>
<br>
But ack that __func__ is acceptable.<br>
<br>
> As for s_upsdebug_ascii() - I do not think it is a perfectly good idea to<br>
> change it (maybe is - not much used in NUT codebase; but possibly some<br>
> forks have more use for it).<br>
> It sounds reasonable however to define and implement a different method for<br>
> this purpose, when you expect that sort of content - and call it where<br>
> suitable.<br>
><br>
> Maybe makes sense to create a typical hexdump printer along the lines of<br>
> <a href="https://gist.github.com/jimklimov/07913a3e30a7d7ec50e9c946117c994f#file-jenkins-credump-L17-L41" rel="noreferrer" target="_blank">https://gist.github.com/jimklimov/07913a3e30a7d7ec50e9c946117c994f#file-jenkins-credump-L17-L41</a><br>
> (that particular code is groovy, but trivial to convert elsewhere).<br>
<br>
I want to see mostly-ascii as mostly-ascii with escapes, because that's<br>
what Fortress output smells like so far, rather than flipping to all<br>
hex (if I read groovy right).<br>
<br>
Totally fair point about not changing s_upsdebug_ascii (but I think we<br>
shouldn't worry about forks as socially they should contribute back). I<br>
will just add a new s_upsdebug_escapedascii and friends -- works for me.<br>
</blockquote></div>