[From nobody Tue Apr 14 13:21:07 2026 Received: (at submit) by bugs.debian.org; 17 Apr 2025 19:09:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02 (2021-04-09) on buxtehude.debian.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=4.0 tests=BAYES_00, BODY_INCLUDES_CONTROL_AFFECTS,FOURLA,MD5_SHA1_SUM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 35; hammy, 150; neutral, 72; spammy, 0. spammytokens: hammytokens:0.000-+--blkid, 0.000-+--sk:partman, 0.000-+--100644, 0.000-+--UD:ext4, 0.000-+--H*rp:D*fr.eu.org Return-path: <pascal@plouf.fr.eu.org> Received: from zenith.ipv6.plouf.fr.eu.org ([2001:7a8:6d23:1::1]:52266 helo=zenith.plouf.fr.eu.org) by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from <pascal@plouf.fr.eu.org>) id 1u5UcW-0039cm-BC for submit@bugs.debian.org; Thu, 17 Apr 2025 19:09:56 +0000 Received: from [192.168.0.247] by zenith.plouf.fr.eu.org with esmtp (Exim 4.89) (envelope-from <pascal@plouf.fr.eu.org>) id 1u5UcP-00049w-Bx for submit@bugs.debian.org; Thu, 17 Apr 2025 21:09:49 +0200 Content-Type: multipart/mixed; boundary="------------7Lyt0aB000gRETm0R1Ed6xnR" Message-ID: <02ee30b0-8c97-4f39-b347-b1553de3fbda@plouf.fr.eu.org> Date: Thu, 17 Apr 2025 21:09:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Debian Bug Tracking System <submit@bugs.debian.org> From: Pascal Hambourg <pascal@plouf.fr.eu.org> Subject: libparted detects ext4 without journal as ext2 Organization: Plouf ! Delivered-To: submit@bugs.debian.org This is a multi-part message in MIME format. --------------7Lyt0aB000gRETm0R1Ed6xnR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Source: parted Version: 3.6-5 Severity: minor Tags: d-i patch Control: affects -1 partman-base partman-basicfilesystems partman-ext3 Dear maintainers, libparted wrongly detects ext4 without journal as ext2 instead of ext4. Steps to reproduce: truncate -s 1G blob mkfs.ext4 -O ^has_journal blob blkid blob -> ext4 parted blob print -> ext2 mount -t ext2 blob /mnt -> "couldn't mount as ext2 due to feature incompatibilities" mount -t ext4 blob /mnt -> ok This bug affects the debian installer partitioning tool, partman, which relies on libparted to detect partition filesystem types. partman accepts to use such ext4 partition (without formatting it) only as ext2, then tries and fails to mount it as ext2 because of incompatible features. In libparted/fs/ext2/interface.c, _ext2_generic_probe() considers ext4 as a subset of ext3 which is ext2 with journal. IMO this is wrong because ext4 without journal may have other incompatible features. I acknowledge that this bug should be brought upstream but could you please have a look at the attached trivial patch (untested) ? --------------7Lyt0aB000gRETm0R1Ed6xnR Content-Type: text/x-patch; charset=UTF-8; name="detect-ext4-nojournal.patch" Content-Disposition: attachment; filename="detect-ext4-nojournal.patch" Content-Transfer-Encoding: base64 RnJvbSBhMjdkYjhkMzE3YzcxZGJhYWNkNTE0NzU3MjEzNjFiZmI0MDQxNTJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXNjYWwgSGFtYm91cmcgPHBhc2NhbEBwbG91Zi5m ci5ldS5vcmc+CkRhdGU6IFRodSwgMTcgQXByIDIwMjUgMTg6NDI6MzMgKzAyMDAKU3ViamVj dDogW1BBVENIXSBsaWJwYXJ0ZWQ6IERvIG5vdCBkZXRlY3QgZXh0NCB3aXRob3V0IGpvdXJu YWwgYXMgZXh0MgoKZXh0NCBtYXkgaGF2ZSBvdGhlciBpbmNvbXBhdGlibGUgZmVhdHVyZXMg dGhhbiBqb3VybmFsIGFuZCBjYW5ub3QgYmUKbW91bnRlZCBhcyBleHQyIGJ5IGxpbnV4LCBz byBkZXRlY3QgaXQgYXMgZXh0NCBldmVuIHdpdGhvdXQgam91cm5hbAppZiBpdCBoYXMgb3Ro ZXIgaW5jb21wYXRpYmxlIGZlYXR1cmVzLgotLS0KIGxpYnBhcnRlZC9mcy9leHQyL2ludGVy ZmFjZS5jIHwgMzMgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlicGFydGVkL2ZzL2V4dDIvaW50ZXJmYWNlLmMgYi9saWJwYXJ0ZWQvZnMvZXh0Mi9p bnRlcmZhY2UuYwppbmRleCA3ZTBiMTk3NC4uNWY2NGFiMzcgMTAwNjQ0Ci0tLSBhL2xpYnBh cnRlZC9mcy9leHQyL2ludGVyZmFjZS5jCisrKyBiL2xpYnBhcnRlZC9mcy9leHQyL2ludGVy ZmFjZS5jCkBAIC01MiwyNCArNTIsMjEgQEAgX2V4dDJfZ2VuZXJpY19wcm9iZSAoUGVkR2Vv bWV0cnkqIGdlb20sIGludCBleHBlY3RfZXh0X3ZlcikKIAkJaW50IGlzX2V4dDMgPSAwOwog CQlpbnQgaXNfZXh0NCA9IDA7CiAKLQkJaXNfZXh0MyA9IChFWFQyX1NVUEVSX0ZFQVRVUkVf Q09NUEFUICgqc2IpCi0JCQkgICAmIEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwp ICE9IDA7Ci0JCWlmIChpc19leHQzKSB7Ci0JCQlpc19leHQ0ID0gKChFWFQyX1NVUEVSX0ZF QVRVUkVfUk9fQ09NUEFUICgqc2IpCi0JCQkJICAgICYgRVhUNF9GRUFUVVJFX1JPX0NPTVBB VF9IVUdFX0ZJTEUpCi0JCQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9ST19DT01QQVQg KCpzYikKLQkJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09NUEFUX0dEVF9DU1VNKQot CQkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVfUk9fQ09NUEFUICgqc2IpCi0JCQkJICAg ICAgICYgRVhUNF9GRUFUVVJFX1JPX0NPTVBBVF9ESVJfTkxJTkspCi0JCQkJICAgfHwgKEVY VDJfU1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQotCQkJCSAgICAgICAmIEVYVDRfRkVB VFVSRV9JTkNPTVBBVF9FWFRFTlRTKQotCQkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVf SU5DT01QQVQgKCpzYikKLQkJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfNjRC SVQpCi0JCQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQotCQkJ CSAgICAgICAmIEVYVDRfRkVBVFVSRV9JTkNPTVBBVF9GTEVYX0JHKSk7Ci0JCQlpZiAoaXNf ZXh0NCkKLQkJCQlpc19leHQzID0gMDsKLQkJfQorCQlpc19leHQ0ID0gKChFWFQyX1NVUEVS X0ZFQVRVUkVfUk9fQ09NUEFUICgqc2IpCisJCQkgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09N UEFUX0hVR0VfRklMRSkKKwkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVfUk9fQ09NUEFU ICgqc2IpCisJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09NUEFUX0dEVF9DU1VNKQor CQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9ST19DT01QQVQgKCpzYikKKwkJCSAgICAg ICAmIEVYVDRfRkVBVFVSRV9ST19DT01QQVRfRElSX05MSU5LKQorCQkJICAgfHwgKEVYVDJf U1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQorCQkJICAgICAgICYgRVhUNF9GRUFUVVJF X0lOQ09NUEFUX0VYVEVOVFMpCisJCQkgICB8fCAoRVhUMl9TVVBFUl9GRUFUVVJFX0lOQ09N UEFUICgqc2IpCisJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfNjRCSVQpCisJ CQkgICB8fCAoRVhUMl9TVVBFUl9GRUFUVVJFX0lOQ09NUEFUICgqc2IpCisJCQkgICAgICAg JiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfRkxFWF9CRykpOworCQlpZiAoIWlzX2V4dDQpCisJ CQlpc19leHQzID0gKEVYVDJfU1VQRVJfRkVBVFVSRV9DT01QQVQgKCpzYikKKwkJCQkgICAm IEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwpICE9IDA7CiAJCWlmIChleHBlY3Rf ZXh0X3ZlciA9PSAyICYmIChpc19leHQzIHx8IGlzX2V4dDQpKQogCQkJcmV0dXJuIE5VTEw7 CiAJCWlmIChleHBlY3RfZXh0X3ZlciA9PSAzICYmICFpc19leHQzKQotLSAKMi4zOS41Cgo= --------------7Lyt0aB000gRETm0R1Ed6xnR-- ]