[Piuparts-commits] [SCM] piuparts git repository branch, master, updated. 0.51

[Andreas Beckmann]

The following commit has been merged in the master branch:
commit bbc8e04677418a00bac061e059b7a91e1bb14cc5
Author: Andreas Beckmann <anbe at debian.org>
Date:   Mon Apr 15 11:24:03 2013 +0200

    lib/db: get_all_packages() returns a list, add get_all_package_names()
    
    returning the dict was exposing an implementation detail
    
    Signed-off-by: Andreas Beckmann <anbe at debian.org>

diff --git a/piuparts-master-backend.py b/piuparts-master-backend.py
index 9138388..6777ff1 100644
--- a/piuparts-master-backend.py
+++ b/piuparts-master-backend.py
@@ -218,7 +218,7 @@ class Master(Protocol):
             packages_file = piupartslib.open_packages_url(packages_url)
             db2 = piupartslib.packagesdb.PackagesFile(packages_file)
             packages_file.close()
-            for package in db.get_all_packages().values():
+            for package in db.get_all_packages():
                 if package["Package"] in db2:
                     package["Version"] = db2[package["Package"]]["Version"]
                 else:
diff --git a/piuparts-report.py b/piuparts-report.py
index f1ebfdb..996ca2a 100644
--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -650,7 +650,7 @@ class Section:
             packages_file = piupartslib.open_packages_url(packages_url)
             db2 = piupartslib.packagesdb.PackagesFile(packages_file)
             packages_file.close()
-            for package in db.get_all_packages().values():
+            for package in db.get_all_packages():
                 if package["Package"] in db2:
                     package["Version"] = db2[package["Package"]]["Version"]
                 else:
@@ -1040,7 +1040,7 @@ class Section:
         maintainers = {}
         source_binary_rows = {}
         sources = ""
-        for source in self._source_db.get_all_packages():
+        for source in self._source_db.get_all_package_names():
             (sourcerows, binaryrows, source_state, maintainer, uploaders) = \
                                self.create_source_summary(source, logs_by_dir)
 
diff --git a/piupartslib/packagesdb.py b/piupartslib/packagesdb.py
index ffa2f62..13e0dfb 100644
--- a/piupartslib/packagesdb.py
+++ b/piupartslib/packagesdb.py
@@ -621,7 +621,11 @@ class PackagesDB:
 
     def get_all_packages(self):
         self._find_all_packages()
-        return self._packages
+        return self._packages.values()
+
+    def get_all_package_names(self):
+        self._find_all_packages()
+        return self._packages.keys()
 
     def get_control_header(self, package_name, header):
         self._find_all_packages()

-- 
piuparts git repository