[Piuparts-commits] [piuparts] 04/06: lib/db: test essential-required packages like regular ones

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch develop
in repository piuparts.

commit 71e771e2301c8428127223855091018ebba643e2
Author: Andreas Beckmann <anbe at debian.org>
Date:   Mon Jan 20 11:33:30 2014 +0100

    lib/db: test essential-required packages like regular ones
    
    do not classify them as essential-required initially
    the install and upgrade tests will be no-ops with an adequate run afterwards
    needed as an early indicator that some essential package is rc-buggy
    
    Signed-off-by: Andreas Beckmann <anbe at debian.org>
---
 debian/changelog          | 2 ++
 piupartslib/packagesdb.py | 7 -------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 4b42ac0..0ae1b51 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,8 @@ piuparts (0.57) UNRELEASED; urgency=low
     - get_best_package_state(): New method that considers successfully tested
       providers of a virtual package if the real package of the same name
       failed. Used for dependency resolution.
+    - No longer special-case packages as essential-required and test them like
+      normal packages (no-op test plus adequate run).  (Closes: #735907)
   * Add more piuparts exceptions.
 
  -- Holger Levsen <holger at debian.org>  Fri, 10 Jan 2014 01:00:43 +0100
diff --git a/piupartslib/packagesdb.py b/piupartslib/packagesdb.py
index 65e64b2..c1ac63e 100644
--- a/piupartslib/packagesdb.py
+++ b/piupartslib/packagesdb.py
@@ -121,10 +121,6 @@ class Package(UserDict.UserDict):
                 vlist += self._parse_dependencies(header)
         return vlist
 
-    def is_testable(self):
-        """Are we testable at all? Required aren't."""
-        return self.get("Priority", "") != "required"
-
     def dump(self, output_file):
         output_file.write("".join(self.headers))
 
@@ -425,9 +421,6 @@ class PackagesDB:
             return "failed-testing"
         if self._logdb.log_exists(package, [self._evil]):
             return "cannot-be-tested"
-        if not package.is_testable():
-            return "essential-required"
-
         return "unknown"
 
     def _compute_package_state(self, package):

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/piuparts/piuparts.git