[Piuparts-commits] [piuparts] 08/09: p-r: don't build the list of unknown failures

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch develop
in repository piuparts.

commit 6761c5bf613b9c1a40e527e8903a70e3d98ef3ff
Author: Andreas Beckmann <anbe at debian.org>
Date:   Sat Feb 22 16:14:18 2014 +0100

    p-r: don't build the list of unknown failures
    
    Signed-off-by: Andreas Beckmann <anbe at debian.org>
---
 debian/changelog   |  2 ++
 piuparts-report.py | 32 --------------------------------
 2 files changed, 2 insertions(+), 32 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 43b96d6..3358792 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,8 @@ piuparts (0.57.1) UNRELEASED; urgency=low
       piuparts-report.
     - Add PackagesDB.get_source(package_name) method, for easy lookup of
       source package names.
+  * piuparts-report.py:
+    - Improve integration of known problem reports generation.
   * master-bin/detect_well_known_errors.py:
     - Classify unclassified failures as unclassified_failures.conf.
 
diff --git a/piuparts-report.py b/piuparts-report.py
index 2496147..f204854 100644
--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -360,18 +360,6 @@ $PACKAGE_LIST</ul>
 <p>Affected packages in $SECTION: $COUNT</p></td></tr>
 """
 
-UNKNOWN_TPL = \
-"""<tr class="titlerow"><td class="titlecell">
-Packages with unknown failures detected in $SECTION, sorted by reverse dependency count.
-</td></tr><tr class="normalrow"><td class="contentcell2">
-<p>Please investigate and improve detection of known error types!</p>
-</td></tr><tr class="titlerow"><td class="alerttitlecell">Please file bugs!</td></tr><tr class="normalrow"><td class="contentcell2" colspan="3">
-<ul>
-$PACKAGE_LIST
-</ul>
-<p>Affected packages in $SECTION: $COUNT</p></td></tr>
-"""
-
 PKG_ERROR_TPL = \
 """<li>$RDEPS - <a href=\"$LOG\">$LOG</a>
     (<a href=\"http://packages.qa.debian.org/$SDIR/$SPKG.html\" target=\"_blank\">PTS</a>)
@@ -1540,26 +1528,6 @@ def update_html(section, html_dir, logdict, problem_list, failures, pkgsdb):
                    logdict,
                    PKG_ERROR_TPL, PROB_TPL, pkgsdb)
 
-    # Make a failure list of all failed packages that don't show up as known
-    failedpkgs = set([x for x in logdict.keys()
-                     if get_where(logdict[x]) != 'pass'])
-    knownfailpkgs = set([failure.pkgspec for failure in failures.failures])
-    unknownsasfailures = [make_failure("", "unknown_failures.conf", x)
-                         for x in failedpkgs.difference(knownfailpkgs)]
-
-    def keyfunc(x, pkgsdb=pkgsdb, logdict=logdict):
-        rdeps = pkgsdb.rrdep_count(get_pkg(x.pkgspec))
-
-        is_failed = get_where(logdict[x.pkgspec]) == "fail"
-
-        return (not is_failed, -rdeps, logdict[x.pkgspec])
-
-    unknownsasfailures.sort(key=keyfunc)
-
-    update_tpl(html_dir, section, problem_list[0], unknownsasfailures,
-               logdict,
-               PKG_ERROR_TPL, UNKNOWN_TPL, pkgsdb)
-
 def dwke_process_section(section, sectiondir, htmldir, problem_list, pkgsdb):
     workdirs = [os.path.join(sectiondir, x) for x in KPR_DIRS]
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/piuparts/piuparts.git