[Piuparts-devel] Fwd: Re: RFC: feature/adequate-tags

[Holger Levsen]

Hi,

I probably should have waiting a bit more with merging this... anyhow.

On Donnerstag, 30. Mai 2013, Andreas Beckmann wrote:
> But we probably won't ever need --fail-if-inadequate (for master-slave
> support) because there is nothing to gain by enabling this.

sure.
 
> We have three possible outcomes of a piuparts test:
> * passed
> * failed, but dependencies can be tested
> * failed, don't test dependencies
> 
> adequate targets the second group

no, actually only the first. It tests the installed package.

> , and right now we report them as "pass"
> and add multiple reports to list them and allow bug reporting
> 
> >> This does not work:
> >> 
> >> -    ("inadequate_error.tpl", "due to logfile containing inadequate
> >> errors"),
> >> +    ("inadequate_exit_issue.tpl", "due to adequate exiting
> >> inadequately"),
> >> 
> >> IIRC the _error.tpl vs. _issue.tpl suffix is currently a significant
> >> property used in piuparts-report.
> > 
> > Yup, I've changed this to exit_issue.tpl. (Re-fetch.)
> 
> ???
> 
> create_and_link_to_analysises has
> 
>             # sucessful logs only have issues and failed logs only have
> errors if (state == "failed-testing" and template[-9:] != "issue.tpl") \

so this WHERE= in the templates is completly pointless?

> I don't think so. There won't be a report for fail/.

works as designed.
 
> PS: if adequate can be used for th emissing copyright check, we could
> consider dropping it from scripst/

sounds right.


cheers,
	Holger


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20130530/1520321a/attachment.pgp>