From 293557b25203749cf4678a22dab000e2bef99a82 Mon Sep 17 00:00:00 2001
From: Serafeim Zanikolas <sez@debian.org>
Date: Mon, 14 Sep 2026 22:39:50 +0200
Subject: [PATCH 2/2] enable new adequate tags for detecting invalid users or
 groups in systemd, D-bus and sysvinit files

---
 known_problems/invalid_dbus_user_or_group.conf     | 10 ++++++++++
 known_problems/invalid_systemd_user_or_group.conf  | 10 ++++++++++
 known_problems/invalid_sysvinit_user_or_group.conf | 10 ++++++++++
 piuparts-report.py                                 | 12 ++++++++++++
 piuparts.py                                        |  3 +++
 5 files changed, 45 insertions(+)
 create mode 100644 known_problems/invalid_dbus_user_or_group.conf
 create mode 100644 known_problems/invalid_systemd_user_or_group.conf
 create mode 100644 known_problems/invalid_sysvinit_user_or_group.conf

diff --git a/known_problems/invalid_dbus_user_or_group.conf b/known_problems/invalid_dbus_user_or_group.conf
new file mode 100644
index 00000000..f8315caf
--- /dev/null
+++ b/known_problems/invalid_dbus_user_or_group.conf
@@ -0,0 +1,10 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .*invalid-dbus-user-or-group'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'invalid-dbus-user-or-group' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'invalid-dbus-user-or-group' which indicates a bug.
+"
diff --git a/known_problems/invalid_systemd_user_or_group.conf b/known_problems/invalid_systemd_user_or_group.conf
new file mode 100644
index 00000000..78153eb1
--- /dev/null
+++ b/known_problems/invalid_systemd_user_or_group.conf
@@ -0,0 +1,10 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .*invalid-systemd-user-or-group'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'invalid-systemd-user-or-group' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'invalid-systemd-user-or-group' which indicates a bug.
+"
diff --git a/known_problems/invalid_sysvinit_user_or_group.conf b/known_problems/invalid_sysvinit_user_or_group.conf
new file mode 100644
index 00000000..8422222b
--- /dev/null
+++ b/known_problems/invalid_sysvinit_user_or_group.conf
@@ -0,0 +1,10 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .*invalid-sysvinit-user-or-group.conf'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'invalid-sysvinit-user-or-group.conf' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'invalid-sysvinit-user-or-group.conf' which indicates a bug.
+"
diff --git a/piuparts-report.py b/piuparts-report.py
index dad0d35a..6bb63146 100644
--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -527,6 +527,18 @@ linktarget_by_template = [
         "packages_have_been_kept_back_issue.tpl",
         "but logfile contains 'packages have been kept back'",
     ),
+    (
+        "invalid_dbus_user_or_group.tpl",
+        "but adequate found that a D-Bus configuration file specifies an invalid user or group",
+    ),
+    (
+        "invalid_systemd_user_or_group.tpl",
+        "but adequate found that a systemd service unit script specifies an invalid user or group",
+    )
+    (
+        "invalid_sysvinit_user_or_group.tpl",
+        "but adequate found that a sysvinit script specifies an invalid user or group",
+    ),
     ("needs_rebuild_issue.tpl", "but logfile recommends to rebuild some packages"),
     ("module_build_error_issue.tpl", "but logfile contains dkms module build failures"),
     ("obsolete_conffiles_issue.tpl", "but logfile reports obsolete conffiles"),
diff --git a/piuparts.py b/piuparts.py
index 6be6b542..0fac9704 100755
--- a/piuparts.py
+++ b/piuparts.py
@@ -1574,6 +1574,9 @@ class Chroot:
             adequate_tags = [
                 "broken-binfmt-detector",
                 "broken-binfmt-interpreter",
+                "invalid-dbus-user-or-group",
+                "invalid-systemd-user-or-group",
+                "invalid-sysvinit-user-or-group",
                 "ldd-failure",
                 "library-not-found",
                 "missing-alternative",
-- 
2.47.3