[Pkg-clamav-devel] Just pushed a get_orig shell script

[Sebastian Andrzej Siewior]

On 2014-07-16 23:53:52 [+0200], Andreas Cadhalpun wrote:
> Hi Sebastian,
Hi Andreas,

> Thanks, this will be useful.
> Looking at it briefly, I noticed the following line:
> 	echo "Something went not according to the plan and there is no "
> 
> I'm not 100% sure if this is intended as joke, or if it should mention what
> is missing... :)

I think the next line should mention the file it was looking for. I will
update the message.

> Also I don't see why mk-origtargz is necessary, instead of e.g. uscan
> --rename.

uscan on its own downloads the archive (-version.tar.gz) and then runs
mk-origtargz which creates the _version.orig.tar.gz. This happens.
However lets assume the new orig is moved (later in the script) and the
script failed later for some reasib. Then the re-run and the re-invocation
of uscan is different. uscan notices that -ver.tar.gz is there and does
nothing. In that case the script notices that orig is missing while the
"full" archive is there and runs mk-origtargz on its own.

If you think that this a bug in uscan, it could be reported as such :)

> >If it is started (now) then it will fetch the 0.94.5beta. I haven't
> >tested the splitted archive.
> 
> s/0.94.5beta/0.98.5beta/ ;)
:)

> >Scott, is this what you were looking for more or less?
> 
> While the script does it's job, I think it would be even nicer to have a
> get-orig-source target in the debian/rules file, because this is recommended
> by policy [1].

Sure, the idea was to add it to debian/rules once it is okay.

> Of course, the target could just call the script, but it would be nice, if
> it worked from any directory and would download the tarball, if the tarball
> for the current version is not present in the current directory.
> (uscan has a --destdir option, which could be used here.)

ah okay. What do you suggest for --destdir? Something static (like there
is now with implicit ..) or you temporary directory created each time?

> Best regards,
> Andreas
> 
> 1: https://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules

Sebastian