[Pkg-clamav-devel] Bug#779501: clamsmtp: patch included in 1.10-12 completely breaks the package

[Julien Cristau]

Package: clamsmtp
Version: 1.10-12
Severity: grave
Justification: renders package unusable
x-debbugs-cc: Michael Tautschnig <mt at debian.org>

Dear maintainer,

the removal of _GNU_SOURCE in 1.10-12 following #703538 means strcasestr
is not declared, which results in

../common/smtppass.c: In function ‘parse_xforward’:
../common/smtppass.c:1206:7: warning: assignment makes pointer from integer without a cast
     t = strcasestr(line, part);
       ^

and in the compiler taking that value as an int instead of a pointer,
which makes things explode on 64bit.  Please either revert that change
or use something like the following and make sure config.h or usuals.h
is always included first in all source files (and in particular
smtppass.c).  And don't ignore compiler warnings next time around :)

Cheers,
Julien

--- clamsmtp-1.10/common/usuals.h       2007-05-27 01:57:56.000000000 +0200
+++ clamsmtp-patched/common/usuals.h    2015-03-01 16:48:10.684201573 +0100
@@ -39,10 +39,10 @@
 #ifndef __USUALS_H__
 #define __USUALS_H__
 
-#include <sys/types.h>
-
 #include "config.h"
 
+#include <sys/types.h>
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <errno.h>
diff -Nru clamsmtp-1.10/configure.in clamsmtp-patched/configure.in
--- clamsmtp-1.10/configure.in  2008-06-30 19:01:48.000000000 +0200
+++ clamsmtp-patched/configure.in       2015-03-01 16:40:02.278986882 +0100
@@ -51,6 +51,8 @@
 AC_PROG_LN_S
 AC_PROG_MAKE_SET
 
+AC_USE_SYSTEM_EXTENSIONS
+
 # Debug mode
 AC_ARG_ENABLE(debug, 
         AC_HELP_STRING([--enable-debug],
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-clamav-devel/attachments/20150301/adeaeffd/attachment.sig>