[Pkg-crosswire-devel] [Branch ~pkgcrosswire/libsword/main] Rev 44: * debian/rules:

[Jonathan Marsden]

Dima,

noreply at launchpad.net wrote:

> +    - tightened download-tarball target to download exactly required version.

> -SOURCE_VER = $(shell echo $(notdir $(SOURCE_DIR)) | sed s/sword-//)
> +SOURCE_VER = $(shell parsechangelog $(dir $(_))changelog | sed -n "s/Version: \(.*\)+dfsg.*/\1/p")
>  
>  download-tarball:
> -	uscan --download --package sword --destdir=$(TEMP_DIR) \
> -	      --no-symlink --upstream-version 0 --watchfile=$(dir $(_))/watch
> +	uscan --force-download --package sword --destdir=$(TEMP_DIR) \
> +	      --no-symlink --upstream-version $(SOURCE_VER) --watchfile=$(dir $(_))watch \
> +	      --download-version $(SOURCE_VER)

Can you explain this change?  When did the earlier approach fail?

I'm concerned that (after your changes) get-orig-source does the wrong
thing when upstream releases a new tarball.  Before, it would
automatically get the newly released tarball, and repack it for us.
Now... I don't see how it does that.  This rule should only ever be
called by hand by a developer doing an update of the packaging for a new
version.

Thanks,

Jonathan