Bug#916496: xcom-ufo: cannot build package from GOG 2.0.0.4 installer

[Timothy Allen]

On Sat, 2018-12-15 at 11:37 +0000, Simon McVittie wrote:
> On Sat, 15 Dec 2018 at 15:22:18 +1100, Timothy Allen wrote:
> > I discovered the "game-data-packager make-template" command;
> > attached
> > is the output from:
> > 
> >     game-data-packager make-template --base xcom-ufo \
> >         setup_xcom_ufo_defense_2.0.0.4.exe
> 
> Does openxcom work if you have the SOUND/ROLAND.CAT from
> setup_xcom_ufo_defense_2.0.0.4.exe instead of the (much smaller) one
> from the current file list, and if you don't have the other files
> listed in "assets not in setup_xcom_ufo_defense_2.0.0.4.exe"?

I extracted the installer with innoextract, and manually copied the
directories listed for Nightly builds in the OpenXcom documentation[1]
to the place where OpenXcom looks, and successfully began a new game
and played a mission. I don't know how exhaustively OpenXcom checks its
datafiles at startup, but it seemed good to me.

I'm not sure how to interpret the "assets not in
setup_xcom_ufo_defense_2.0.0.4.exe" section. For example, it starts off
looking for a file named "GEODATA/BIGLETS.DAT" with an MD5 of 6a2b1...
and it's correct that such a file doesn't exist. The setup file's
BIGLETS.DAT has an MD5 of 9f20e... and the generated manifest maps that
MD5sum to the name "GEODATA/BIGLETS.DAT?orig". In fact, all the "assets
not in setup..." other than ROLAND.CAT are all in the "obsolete" group
with the "?orig" suffix.

[1]: https://www.ufopaedia.org/index.php?title=Installing_(OpenXcom)

> Are any of the other files listed in "remaining contents of
> setup_xcom_ufo_defense_2.0.0.4.exe" required?

If I delete the SOUND/* files and UFOINTRO/* files listed in "remaining
contents..." (other than SOUND/ROLAND.CAT) then OpenXcom still works,
so I guess they're not required.

None of the other "remaining contents..." are mentioned in the OpenXcom
docs, so I guess they're irrelevant.