Bug#990923: minetest-data: Crash in falling.lua

[Craig Small]

Package: minetest-data
Version: 5.3.0+repack-2
Severity: normal

Hi,
  falling.lua has a bug where if param2 is not defined it crashes.


2021-07-11 15:01:10: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '*builtin*' in callback luaentity_Activate(): /usr/share/games/minetest/builtin/game/falling.lua:154: attempt to perform arithmetic on field 'param2' (a nil value)

I'm not sure why param2 is not defined but its a simple fix, see patch.

 - Craig


-- System Information:
Debian Release: 10.10
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-17-amd64 (SMP w/1 CPU core)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages minetest-data depends on:
ii  fonts-croscore        20201225-1
ii  fonts-droid-fallback  1:6.0.1r16-1.1

minetest-data recommends no packages.

minetest-data suggests no packages.

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/games/minetest/builtin/game/falling.lua (from minetest-data package)
-------------- next part --------------
147c147
< 		elseif (node.param2 ~= 0 and (def.wield_image == ""
---
> 		elseif (node.param2 ~= nil and (def.wield_image == ""
154c154
< 				local fdir = node.param2 % 32
---
> 				local fdir = (node.param2 or 0) % 32