Bug#1069298: libsfml FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Helmut Grohne]

Source: libsfml
Version: 2.6.1+dfsg-2
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

libsfml fails to cross build from source, because it fails running its
test suite despite being given DEB_BUILD_OPTIONS=nocheck. I'm attaching
a patch to add support for disabling tests and verified that doing so
does not affect the output artifacst via reproducible builds.

Helmut
-------------- next part --------------
diff --minimal -Nru libsfml-2.6.1+dfsg/debian/changelog libsfml-2.6.1+dfsg/debian/changelog
--- libsfml-2.6.1+dfsg/debian/changelog	2023-12-02 12:33:22.000000000 +0100
+++ libsfml-2.6.1+dfsg/debian/changelog	2024-04-19 08:28:52.000000000 +0200
@@ -1,3 +1,10 @@
+libsfml (2.6.1+dfsg-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Support DEB_BUILD_OPTIONS=nocheck. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Fri, 19 Apr 2024 08:28:52 +0200
+
 libsfml (2.6.1+dfsg-2) unstable; urgency=medium
 
   * Upload to unstable.
diff --minimal -Nru libsfml-2.6.1+dfsg/debian/control libsfml-2.6.1+dfsg/debian/control
--- libsfml-2.6.1+dfsg/debian/control	2023-12-02 12:33:22.000000000 +0100
+++ libsfml-2.6.1+dfsg/debian/control	2024-04-19 08:28:27.000000000 +0200
@@ -6,7 +6,7 @@
  James Cowgill <jcowgill at debian.org>
 Build-Depends: debhelper-compat (= 13),
  cmake,
- catch,
+ catch <!nocheck>,
  doxygen,
  libflac-dev,
  libfreetype-dev,
diff --minimal -Nru libsfml-2.6.1+dfsg/debian/rules libsfml-2.6.1+dfsg/debian/rules
--- libsfml-2.6.1+dfsg/debian/rules	2023-12-02 12:33:22.000000000 +0100
+++ libsfml-2.6.1+dfsg/debian/rules	2024-04-19 08:28:50.000000000 +0200
@@ -8,7 +8,7 @@
 	dh_auto_configure -- \
 		-DSFML_BUILD_DOC=ON \
 		-DSFML_BUILD_EXAMPLES=ON \
-		-DSFML_BUILD_TEST_SUITE=ON
+		-DSFML_BUILD_TEST_SUITE=$(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),OFF,ON)
 
 override_dh_auto_build:
 	dh_auto_build -- all doc