Bug#1066255: asciijump: FTBFS: scrclient.c:76:19: error: implicit declaration of function =?UTF-8?Q?=E2=80=98strtol=E2=80=99; ?= did you mean ‘strtok’? [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: asciijump
Version: 1.0.2~beta-10
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> creating client {
> 
> 
> 
> scrclient.c .. xfnc.c .. 
> scrcup.c .. scrmain.c .. scrresult.c .. 
> 
> scrtrain.c .. 
> cmdline.c .. wsys.c .. scrclient.c: In function ‘cl_set_port’:
> scrclient.c:76:19: error: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Werror=implicit-function-declaration]
>    76 |         cl_port = strtol(s, NULL, 10);
>       |                   ^~~~~~
>       |                   strtok
> scrcup.c: In function ‘cup_init’:
> scrcup.c:178:17: error: implicit declaration of function ‘rs_actions’ [-Werror=implicit-function-declaration]
>   178 |                 rs_actions(cup_show, mn_scr_show);
>       |                 ^~~~~~~~~~
> ok
> frame.c .. ok
> skier.c .. okcc1: some warnings being treated as errors
> 
> make[1]: *** [Makefile:96: bin/scrclient.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/asciijump_1.0.2~beta-10_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.