Bug#1066253: penguin-command: FTBFS: joystick.c:9:45: error: implicit declaration of function ‘ComplainAndExit’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: penguin-command
Version: 1.6.11-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"penguin-command\" -DVERSION=\"1.6.11\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_MATH_H=1 -DHAVE_LIBZ=1 -DHAVE_LIBM=1 -DHAVE_LIBSDL_IMAGE=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DUSE_SOUND -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -Wall -DJOYSTICK -DDATADIR="\"/usr/share/games/penguin-command\"" -MT joystick.o -MD -MP -MF .deps/joystick.Tpo -c -o joystick.o joystick.c
> joystick.c: In function ‘JoystickInit’:
> joystick.c:9:45: error: implicit declaration of function ‘ComplainAndExit’ [-Werror=implicit-function-declaration]
>     9 |     if ( SDL_Init(SDL_INIT_JOYSTICK ) < 0 ) ComplainAndExit();
>       |                                             ^~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:404: joystick.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/penguin-command_1.6.11-3_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.