r20940 - in /packages/unstable/update-manager/debian: ./ patches/ pos/

[Julian Andres Klode]

On Sun, Aug 16, 2009 at 05:57:14PM +0200, Emilio Pozuelo Monfort wrote:
> Hi Stephan,
> 
> I have a few comments about the update:

> 
> update-manager-core depends on update-manager-gnome, and viceversa. I think
> that's problematic. I'd remove the update-manager-core dependency, and let
> update-manager-gnome (and other frontends when they are written) depend on the
> backend, to break the dependency loop.
Same for me. Cyclic dependencies are never a good idea. But you could still 
recommend or suggest update-manager-gnome.

> 
> > -include /usr/share/gnome-pkg-tools/1/rules/uploaders.mk
> 
> You're removing our team magic!
We should really add a sequence to debhelper, so we could write rule files like:
	%:
		dh --with gnome $@
Than we would not need cdbs anymore.

> > +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/Ubuntu/
> 
> Maybe you should write a setup.py script upstream? ;)
Just want to say that there is a debian/tmp/ prefix, so I guess it is installed
by setup.py. Anyway, if those modules are only used by applications inside this
package they should be moved to /usr/share/update-manager/UpdateManager, as required
by the Python Policy 2.1, as they don't have to be in the global Python path.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090816/e925d8f2/attachment-0001.pgp>