Bug#784219: fixed upstream
Andreas Henriksson
andreas at fatal.se
Wed Jul 15 13:28:57 UTC 2015
Control: tags -1 + fixed-upstream
The problem is fixed upstream by this commit:
https://git.gnome.org/browse/evince/patch/?id=557a93e9cf5bc16c0e6eed
I've verified that it backports cleanly to 3.14.2 and fixes the problem.
I've attached a debdiff that updates the 3.14.2-1 package (available from
http://snapshot.debian.org/package/evince/3.14.2-1/ ) to include the
patch.
This is already fixed in 3.17.3 development release and should end up in
Debian unstable once we update to 3.18.
Regards,
Andreas Henriksson
-------------- next part --------------
diff -Nru evince-3.14.2/debian/changelog evince-3.14.2/debian/changelog
--- evince-3.14.2/debian/changelog 2015-06-17 16:32:33.000000000 +0200
+++ evince-3.14.2/debian/changelog 2015-07-15 14:36:14.000000000 +0200
@@ -1,3 +1,11 @@
+evince (3.14.2-2) UNRELEASED; urgency=medium
+
+ * Add debian/patches/tab-scroll-fix.patch from
+ https://git.gnome.org/browse/evince/patch/?id=557a93e9cf5bc16c0e
+ (Closes: #784219)
+
+ -- Andreas Henriksson <andreas at fatal.se> Wed, 15 Jul 2015 14:35:01 +0200
+
evince (3.14.2-1) unstable; urgency=medium
* New upstream release.
diff -Nru evince-3.14.2/debian/patches/series evince-3.14.2/debian/patches/series
--- evince-3.14.2/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ evince-3.14.2/debian/patches/series 2015-07-15 14:36:47.000000000 +0200
@@ -0,0 +1 @@
+tab-scroll-fix.patch
diff -Nru evince-3.14.2/debian/patches/tab-scroll-fix.patch evince-3.14.2/debian/patches/tab-scroll-fix.patch
--- evince-3.14.2/debian/patches/tab-scroll-fix.patch 1970-01-01 01:00:00.000000000 +0100
+++ evince-3.14.2/debian/patches/tab-scroll-fix.patch 2015-07-15 14:36:41.000000000 +0200
@@ -0,0 +1,52 @@
+From 557a93e9cf5bc16c0e6eed1607e3b2cc7001997d Mon Sep 17 00:00:00 2001
+From: Carlos Garcia Campos <carlosgc at gnome.org>
+Date: Thu, 4 Jun 2015 12:04:01 +0200
+Subject: libview: Only try to move the focus to different page when the
+ current page has a focused element
+
+This prevents the view from jumping to the first/last page when there
+are not focusable elements.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=741979
+
+diff --git a/libview/ev-view.c b/libview/ev-view.c
+index 3fc4584..84f1d49 100644
+--- a/libview/ev-view.c
++++ b/libview/ev-view.c
+@@ -6825,6 +6825,7 @@ ev_view_focus_next (EvView *view,
+ {
+ EvMapping *focus_element;
+ GList *elements;
++ gboolean had_focused_element;
+
+ if (view->focused_element) {
+ GList *l;
+@@ -6833,9 +6834,11 @@ ev_view_focus_next (EvView *view,
+ l = g_list_find (elements, view->focused_element);
+ l = g_list_next (l);
+ focus_element = l ? l->data : NULL;
++ had_focused_element = TRUE;
+ } else {
+ elements = ev_view_get_sorted_mapping_list (view, direction, view->current_page);
+ focus_element = elements ? elements->data : NULL;
++ had_focused_element = FALSE;
+ }
+
+ g_list_free (elements);
+@@ -6850,6 +6853,13 @@ ev_view_focus_next (EvView *view,
+ ev_view_remove_all (view);
+ _ev_view_set_focused_element (view, NULL, -1);
+
++ /* Only try to move the focus to next/previous pages when the current page had
++ * a focused element. This prevents the view from jumping to the first/last page
++ * when there are not focusable elements.
++ */
++ if (!had_focused_element)
++ return FALSE;
++
+ /* FIXME: this doesn't work if the next/previous page doesn't have form fields */
+ if (direction == GTK_DIR_TAB_FORWARD) {
+ if (ev_view_next_page (view)) {
+--
+cgit v0.10.2
+
More information about the pkg-gnome-maintainers
mailing list