Bug#888485: fixed in gjs 1.50.3-2

[Simon McVittie]

On Fri, 26 Jan 2018 at 21:38:20 +0100, Raphael Hertzog wrote:
> On Fri, 26 Jan 2018 17:37:32 +0000 Simon McVittie <smcv at debian.org> wrote:
> >    * Revert some of the upstream changes from 1.50.3, which appear to
> >      cause crashes (Closes: #888485; possibly also #888052, #888199)
> 
> With this version, I no longer have the crash and I see errors logged

OK, that's a good start. Hopefully upstream can work out how to avoid
the crash while not reverting those three commits.

> Jan 26 21:28:01 kali-rolling org.gnome.Shell.desktop[885]: #0 0x56294fcf2b98 i   /usr/share/gnome-shell/extensions/places-menu at gnome-shell-extensions.gcampax.github.com/placeDisplay.js:146 (0x7f0c31806d58 @ 67)

This is the sort of logging you should have been getting as a result of
the remaining (non-reverted) changes in 1.50.3. It probably indicates
a bug in the Places extension's JS code.

#888485 is really two bugs:

* the Places extension continues to use objects after they've been
  destroyed (this is the Places extension's fault);
* when that happens, gjs treats it as an uncatchable exception instead
  of coping gracefully, for reasons I don't fully understand yet
  (this is gjs' fault)

I believe the first part is a known upstream bug in the Places extension,
which is already fixed upstream. I deliberately haven't applied that
change because this is the only way I was able to reproduce the second
part, which is believed to be related to #888052 and #888199 (which I
don't know how to reproduce or test).

Reverting the three commits that I reverted in 1.50.3-2 seems to avoid
the second part.

There are also bugs similar to the first part in gnome-shell itself,
although they don't cause crashes (that I've seen). Some or perhaps all
of them are fixed in experimental, including #887082 (I didn't fix those
in unstable yet, because that involves several unreviewed patches).

    smcv