Bug#1046520: mozjs102: Fails to build source after successful build

[Lucas Nussbaum]

Source: mozjs102
Version: 102.14.0-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package mozjs102
> dpkg-buildpackage: info: source version 102.14.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jeremy Bícha <jbicha at ubuntu.com>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --sourcedirectory=/<<PKGBUILDDIR>>/js/src --builddirectory=/<<PKGBUILDDIR>>/debian/build --with gnome,pkgkde-symbolshelper
>    dh_auto_clean -O--sourcedirectory=/<<PKGBUILDDIR>>/js/src -O--builddirectory=/<<PKGBUILDDIR>>/debian/build
>    dh_autoreconf_clean -O--sourcedirectory=/<<PKGBUILDDIR>>/js/src -O--builddirectory=/<<PKGBUILDDIR>>/debian/build
>    dh_gnome_clean -O--sourcedirectory=/<<PKGBUILDDIR>>/js/src -O--builddirectory=/<<PKGBUILDDIR>>/debian/build
>    debian/rules override_dh_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_clean
> find /<<PKGBUILDDIR>> -name \*.pyc -exec rm {} \;
> find /<<PKGBUILDDIR>>/js/src/ -type l -exec rm {} \;
> rm -f /<<PKGBUILDDIR>>/js/src/config/nsinstall
> rm -f /<<PKGBUILDDIR>>/js/src/dist/bin/.purgecaches
> rm -f  /<<PKGBUILDDIR>>/js/src/js102-config \
> 	/<<PKGBUILDDIR>>/js/src/mozjs-102.pc \
> 	/<<PKGBUILDDIR>>/js/src/symverscript
> rm -f /<<PKGBUILDDIR>>/js/src/config.log
> # rm -f /<<PKGBUILDDIR>>/js/src/configure
> rm -fr /<<PKGBUILDDIR>>/intl/icu/source/autom4te.cache
> rm -fr /<<PKGBUILDDIR>>/debian/build
> rm -rf third_party/python/psutil/build/ third_party/python/psutil/psutil/_*.so third_party/python/psutil/tmp/
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>  dpkg-source -b .
> dpkg-source: warning: upstream signing key but no upstream tarball signature
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building mozjs102 using existing ./mozjs102_102.14.0.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file intl/icu/source/install-sh, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file intl/icu/source/aclocal.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file intl/icu/source/configure, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file js/src/old-configure, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file js/src/configure, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  mozjs102-102.14.0/Cargo.lock
>  mozjs102-102.14.0/js/src/tests/main_raw.log
>  mozjs102-102.14.0/main_raw.log
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/mozjs102_102.14.0-1.diff.GLQ1BM
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/mozjs102_102.14.0-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.