[pkg-gnupg-maint] Bug#1063733: no -D_TIME_BITS=64 on builds where t64 support is supposed to be done

[Sven Joachim]

On 2024-02-11 22:10 +0100, Rene Engelhard wrote:

> Source: gpgme1.0
> Version: 1.18.0-4.1~exp1
> Severity: important
>
> [ let's no get into a discussion on  the sense of this transition. I
> actually believe this isn't needed and we can leave 32 bit die in 2038
> but anyways...
>
> The transition is ongoing now in experimental. So be it ]
>
>
> Hi,
>
>
> I just tried a rebuild of libreoffice with
> DEB_HOST_MAINT_OPTIONS="abi=+time64" to actually see what happens.
>
> It failed in a certificate unit tests so I tried to rebuild the
> "certificate" related (build-)dependencies also with
> DEB_HOST_MAINT_OPTIONS="abi=+time64"

The correct variable is DEB_BUILD_MAINT_OPTIONS, as you have already
noticed.

> While doing so I noticed that gpgme1.0 doesn't define -D_TIME_BITS=64
> even when built for t64 (as in the experimental NMU renaming to t64)
> on the affected architectures (anything 32-bit except i386).
>
> This is probably because it doesn't honout dpkg-buildflags.

No, this is because debian/rules already sets DEB_BUILD_MAINT_OPTIONS,
overriding the value from the environment.  Either add abi=+time64 there
or set DEB_BUILD_OPTIONS rather than DEB_BUILD_MAINT_OPTIONS in the
environment.

I don't think there is a bug here.

Cheers,
       Sven