<html><body><div class="gmail_quote" dir="ltr">Hi dkg, all,</div><div class="gmail_quote" dir="ltr"><br></div><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" type="cite"><div><div>```<br># See the below link for why we need GSM_SKIP_SSH_AGENT_WORKAROUND:<br># <a href="https://git.gnome.org/browse/gnome-session/tree/gnome-session/main.c?h=3.24.0#n419">https://git.gnome.org/browse/gnome-session/tree/gnome-session/main.c?h=3.24.0#n419</a><br># in order to avoid race condition this environment should be set before SSH_AUTH_SOCK<br>ExecStartPre=systemctl --user set-environment GSM_SKIP_SSH_AGENT_WORKAROUND="true"<br>```<br><br>The link above doesn't say anything about GSM_SKIP_SSH_AGENT_WORKAROUND.<br><br></div></div></blockquote><div class="gmail_quote"><br></div><div class="gmail_quote" dir="ltr">It did at the time (looks like gnome's gitlab redirect has subtly broken the link by omitting the h param).</div><div class="gmail_quote" dir="ltr"><br></div><div class="gmail_quote" dir="ltr">The line referenced was this:</div><div class="gmail_quote" dir="ltr"><a href="https://gitlab.gnome.org/GNOME/gnome-session/-/blob/3.24.0/gnome-session/main.c?ref_type=tags#L419">https://gitlab.gnome.org/GNOME/gnome-session/-/blob/3.24.0/gnome-session/main.c?ref_type=tags#L419</a></div><div class="gmail_quote"><br></div><div class="gmail_quote" dir="ltr">introduced in this commit:</div><div class="gmail_quote" dir="ltr"><a href="https://gitlab.gnome.org/GNOME/gnome-session/-/commit/a8896ccad65583885735a04205351f48a42f29ae">https://gitlab.gnome.org/GNOME/gnome-session/-/commit/a8896ccad65583885735a04205351f48a42f29ae</a></div><div class="gmail_quote"><br></div><div class="gmail_quote" dir="ltr">and as you say, the proper fix was then included in 3.25.3, and GSM_SKIP_SSH_AGENT_WORKAROUND became unnecessary once we started shipping versions newer than this.</div><div class="gmail_quote"><br></div><div class="gmail_quote"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" type="cite"><div><div>so i think this is safe to remove.<br></div></div></blockquote><div class="gmail_quote"><br></div><div class="gmail_quote" dir="ltr">I agree! Thank you for following up on this.</div><div class="gmail_quote" dir="ltr"><br></div><div class="gmail_quote" dir="ltr"><br></div><div class="gmail_quote" dir="ltr"> -- rufo</div>
</div></body></html>