tilemaker review

[Sebastiaan Couwenberg]

tilemaker:


 * debian/changelog

   Entry closing the ITP should be the first as it's the most prominent
   change.


 * debian/control

   Package description is probably too short.

   Use liblua5.1-dev instead.


 * debian/copyright:

   Upstream-Name starts with a capital letter.

   License for include/rapidjson/msinttypes/inttypes.h &
   include/rapidjson/msinttypes/stdint.h is incorrect.

   License & copyright is missing for include/geometry/correct.hpp.

   See: licensecheck --deb-machine -r *

   License for include/osmformat.proto is LGPL-3+, see:


https://salsa.debian.org/debian-gis-team/osmpbf/-/blob/master/debian/copyright

   License for resources/process-openmaptiles.lua is CC-BY-4.0.



 * debian/patches/0002-Avoid-calling-git-outside-of-repository.patch

   Use `dpkg-parsechangelog -S Version` instead of egrep.
   See /usr/share/dpkg/pkg-info.mk and possibly use those vars when set
   in the environment.


 * debian/patches/0004-Rely-on-packaged-rapidjson-dependency.patch

   Removing so many files in a patch is fragile, repacking using
   Files-Excluded may be better.


 * lintian

   debug-file-with-no-debug-symbols
   -g is missing from CFLAGS.

   hardening-no-fortify-functions
   CPPFLAGS is not used.

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1