<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">
The changes for the extent parsing looks good to me. But, I am not sure about this change:
<div>
<pre style="font-variant-ligatures: normal; orphans: 2; widows: 2; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">><i> - if (filename + direntry->len - 1 > (char *) tail)</i>
><i> + if (filename + direntry->len - 1 > (char *) end)</i></pre>
<div>Looking at the grub_xfs_next_de(), should the ‘+1’ be ‘+3’? </div>
<div>
<pre class="c-mrkdwn__pre" data-stringify-type="pre" style="box-sizing: inherit; margin-top: 4px; margin-bottom: 4px; padding: 8px; overflow-wrap: break-word; font-variant-ligatures: none; line-height: 1.50001; tab-size: 4; white-space: pre-wrap; word-break: normal; border: 1px solid var(--saf-0); border-radius: 4px; overflow-y: hidden; counter-reset: list-0 0 list-1 0 list-2 0 list-3 0 list-4 0 list-5 0 list-6 0 list-7 0 list-8 0 list-9 0; color: rgb(29, 28, 29); orphans: 2; widows: 2; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><font face="Helvetica"><span class="c-mrkdwn__highlight" style="box-sizing: inherit; background: rgba(242, 199, 68, 0.4);">grub</span>_xfs_next_de(struct <span class="c-mrkdwn__highlight" style="box-sizing: inherit; background: rgba(242, 199, 68, 0.4);">grub</span>_xfs_data *data, struct <span class="c-mrkdwn__highlight" style="box-sizing: inherit; background: rgba(242, 199, 68, 0.4);">grub</span>_xfs_dir2_entry *de)
{
int size = sizeof (struct <span class="c-mrkdwn__highlight" style="box-sizing: inherit; background: rgba(242, 199, 68, 0.4);">grub</span>_xfs_dir2_entry) + de->len + 2 /* Tag */;
if (data->hasftype)
size++; /* File type */
return (struct <span class="c-mrkdwn__highlight" style="box-sizing: inherit; background: rgba(242, 199, 68, 0.4);">grub</span>_xfs_dir2_entry *)(((char *)de) + ALIGN_UP(size, 8));
}</font></pre>
<pre class="c-mrkdwn__pre" data-stringify-type="pre" style="box-sizing: inherit; margin-top: 4px; margin-bottom: 4px; padding: 8px; overflow-wrap: break-word; font-variant-ligatures: none; line-height: 1.50001; tab-size: 4; white-space: pre-wrap; word-break: normal; border: 1px solid var(--saf-0); border-radius: 4px; overflow-y: hidden; counter-reset: list-0 0 list-1 0 list-2 0 list-3 0 list-4 0 list-5 0 list-6 0 list-7 0 list-8 0 list-9 0; color: rgb(29, 28, 29); orphans: 2; widows: 2; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><font face="Helvetica">Thanks,</font></pre>
<pre class="c-mrkdwn__pre" data-stringify-type="pre" style="box-sizing: inherit; margin-top: 4px; margin-bottom: 4px; padding: 8px; overflow-wrap: break-word; font-variant-ligatures: none; line-height: 1.50001; tab-size: 4; white-space: pre-wrap; word-break: normal; border: 1px solid var(--saf-0); border-radius: 4px; overflow-y: hidden; counter-reset: list-0 0 list-1 0 list-2 0 list-3 0 list-4 0 list-5 0 list-6 0 list-7 0 list-8 0 list-9 0; color: rgb(29, 28, 29); orphans: 2; widows: 2; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><font face="Helvetica">Lidong</font></pre>
<pre class="c-mrkdwn__pre" data-stringify-type="pre" style="box-sizing: inherit; margin-top: 4px; margin-bottom: 4px; padding: 8px; overflow-wrap: break-word; font-variant-ligatures: none; line-height: 1.50001; tab-size: 4; white-space: pre-wrap; word-break: normal; border: 1px solid var(--saf-0); border-radius: 4px; overflow-y: hidden; counter-reset: list-0 0 list-1 0 list-2 0 list-3 0 list-4 0 list-5 0 list-6 0 list-7 0 list-8 0 list-9 0; color: rgb(29, 28, 29); orphans: 2; widows: 2; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><font face="Helvetica"><br></font></pre>
<blockquote type="cite">
<div>On Sep 27, 2023, at 6:45 PM, Jon DeVree <nuxi@vault24.org> wrote:</div>
<br class="Apple-interchange-newline">
<div>
<div>On Fri, Sep 15, 2023 at 23:43:28 +0200, Sebastian Andrzej Siewior wrote:<br>
<blockquote type="cite">
<blockquote type="cite">there's now a patch from Jon DeVree upstream, which might fix this for<br>
you. Is it possible for you to test his patch?<br>
<br>
https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00059.html<br>
</blockquote>
<br>
Yes it sovles the issue, the box boots.<br>
<br>
</blockquote>
<br>
I posted an updated v3 version of the patch:<br>
<br>
https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00110.html<br>
<br>
-- <br>
Jon<br>
Doge Wrangler<br>
X(7): A program for managing terminal windows. See also screen(1) and tmux(1).<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</body>
</html>