Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

[Sean Whitton]

Hello,

On Mon 02 May 2022 at 12:51PM -04, Joey Hess wrote:

> Joey Hess wrote:
>> The rsync command that git-annex runs has a trailing close quote, as
>> seen in the first excerpt above. But rsync then complains about the path
>> with that close quote removed.
>>
>> I'm having a hard time not seeing this as a bug in rsync.
>
> # NEWS for rsync 3.2.4 (15 Apr 2022)
>
> ## Changes in this version:
>
> ### BEHAVIOR CHANGES:
>
>  - A new form of arg protection was added that works similarly to the older
>    [`--protect-args`](rsync.1#opt) (`-s`) option but in a way that avoids
>    breaking things like rrsync (the restricted rsync script): rsync now uses
>    backslash escaping for sending "shell-active" characters to the remote
>    shell. This includes spaces, so fetching a remote file via a simple quoted
>    filename value now works by default without any extra quoting
>
> This change must be the cause of the problem.
>
> git-annex can be configured to not do its own shell escaping when accessing
> a rsync special remote. If your remote is named "foo", you can configure it
> that way as follows:
>
> 	git-annex enableremote foo shellescape=no

Thanks for looking into it.  Do you see this as a workaround or what
people using newer rsync should use going forward?

-- 
Sean Whitton