[testng] 101/355: Invoker: simplify exception in parameters provider case of method invocation.

[Eugene Zhukov]

This is an automated email from the git hooks/post-receive script.

eugene-guest pushed a commit to annotated tag OpenBSD
in repository testng.

commit 4dd8f4768197b043fdb3876ec203e8618c69015b
Author: Vladislav Rassokhin <vladrassokhin at gmail.com>
Date:   Sun Nov 23 02:55:43 2014 +0300

    Invoker: simplify exception in parameters provider case of method invocation.
---
 src/main/java/org/testng/internal/Invoker.java | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/testng/internal/Invoker.java b/src/main/java/org/testng/internal/Invoker.java
index f5d9d9b..4b46ac9 100644
--- a/src/main/java/org/testng/internal/Invoker.java
+++ b/src/main/java/org/testng/internal/Invoker.java
@@ -1067,7 +1067,7 @@ public class Invoker implements IInvoker {
    *
    * Note (alex): this method can be refactored to use a SingleTestMethodWorker that
    * directly invokes
-   * {@link #invokeTestMethod(Object[], ITestNGMethod, Object[], XmlSuite, Map, ITestClass, ITestNGMethod[], ITestNGMethod[], ConfigurationGroupMethods)}
+   * {@link #invokeTestMethod(Object, ITestNGMethod, Object[], int, XmlSuite, Map, ITestClass, ITestNGMethod[], ITestNGMethod[], ConfigurationGroupMethods, FailureContext)}
    * and this would simplify the implementation (see how DataTestMethodWorker is used)
    */
   @Override
@@ -1141,12 +1141,10 @@ public class Invoker implements IInvoker {
             parameters, allParameterNames, suite, testContext, instance);
 
         if (bag.hasErrors()) {
-          handleInvocationResults(testMethod,
-              Lists.newArrayList(bag.errorResult), expectedExceptionHolder, true,
-              true /* collect results */, failure);
-          ITestResult tr = registerSkippedTestResult(testMethod, instance,
-              System.currentTimeMillis(),
-              bag.errorResult.getThrowable());
+          final ITestResult tr = bag.errorResult;
+          tr.setStatus(ITestResult.SKIP);
+          runTestListeners(tr);
+          m_notifier.addSkippedTest(testMethod, tr);
           result.add(tr);
           continue;
         }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/testng.git