[testng] 114/355: testng-562 testNG not creating HTML report Seems XMLStringBuffer#EOL is null sometimes.

[Eugene Zhukov]

This is an automated email from the git hooks/post-receive script.

eugene-guest pushed a commit to annotated tag OpenBSD
in repository testng.

commit 3a1aa91df75f070d3aa8bd0db368b3d9206ac2ba
Author: Vladislav Rassokhin <vladislav.rassokhin at jetbrains.com>
Date:   Fri Jan 9 14:31:32 2015 +0300

    testng-562 testNG not creating HTML report
    Seems XMLStringBuffer#EOL is null sometimes.
---
 src/main/java/org/testng/reporters/FileStringBuffer.java | 6 ++++++
 src/main/java/org/testng/reporters/XMLStringBuffer.java  | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/testng/reporters/FileStringBuffer.java b/src/main/java/org/testng/reporters/FileStringBuffer.java
index 80e774e..af2e98b 100644
--- a/src/main/java/org/testng/reporters/FileStringBuffer.java
+++ b/src/main/java/org/testng/reporters/FileStringBuffer.java
@@ -43,6 +43,9 @@ public class FileStringBuffer implements IBuffer {
 
   @Override
   public FileStringBuffer append(CharSequence s) {
+    if (s == null) {
+      throw new IllegalArgumentException("CharSequence (Argument 0 of FileStringBuffer#append) should not be null");
+    }
 //    m_sb.append(s);
     if (m_sb.length() > m_maxCharacters) {
       flushToFile();
@@ -64,6 +67,9 @@ public class FileStringBuffer implements IBuffer {
 
   @Override
   public void toWriter(Writer fw) {
+    if (fw == null) {
+      throw new IllegalArgumentException("Writer (Argument 0 of FileStringBuffer#toWriter) should not be null");
+    }
     try {
       BufferedWriter bw = new BufferedWriter(fw);
       if (m_file == null) {
diff --git a/src/main/java/org/testng/reporters/XMLStringBuffer.java b/src/main/java/org/testng/reporters/XMLStringBuffer.java
index 092c10e..84046b4 100755
--- a/src/main/java/org/testng/reporters/XMLStringBuffer.java
+++ b/src/main/java/org/testng/reporters/XMLStringBuffer.java
@@ -14,8 +14,8 @@ import java.util.regex.Pattern;
  * @author <a href="mailto:cedric at beust.com">Cedric Beust</a> Jul 21, 2003
  */
 public class XMLStringBuffer {
-  /** End of line */
-  private static final String EOL = System.getProperty("line.separator");
+  /** End of line, value of 'line.separator' system property or '\n' */
+  private static final String EOL = System.getProperty("line.separator", "\n");
 
   /** Tab space indent for XML document */
   private static final String DEFAULT_INDENT_INCREMENT = "  ";

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/testng.git