Bug#1043785: async-http-client: Fails to build source after successful build

[Lucas Nussbaum]

Source: async-http-client
Version: 2.12.3-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package async-http-client
> dpkg-buildpackage: info: source version 2.12.3-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Emmanuel Bourg <ebourg at apache.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	mh_patchpoms -plibasync-http-client-java --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf -Dproperties.file.manual=/<<PKGBUILDDIR>>/debian/maven.properties org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode clean
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Build Order:
> [INFO] 
> [INFO] Asynchronous Http Client Project                                   [pom]
> [INFO] Asynchronous Http Client Netty Utils                               [jar]
> [INFO] Asynchronous Http Client                                           [jar]
> [INFO] 
> [INFO] -----------< org.asynchttpclient:async-http-client-project >------------
> [INFO] Building Asynchronous Http Client Project 2.12.3                   [1/3]
> [INFO] --------------------------------[ pom ]---------------------------------
> [WARNING] The artifact org.apache.maven.plugins:maven-clean-plugin:jar:2.5 has been relocated to org.apache.maven.plugins:maven-clean-plugin:jar:3.2.0
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ async-http-client-project ---
> [INFO] Deleting /<<PKGBUILDDIR>>/target
> [INFO] 
> [INFO] ---------< org.asynchttpclient:async-http-client-netty-utils >----------
> [INFO] Building Asynchronous Http Client Netty Utils 2.12.3               [2/3]
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ async-http-client-netty-utils ---
> [INFO] Deleting /<<PKGBUILDDIR>>/netty-utils/target
> [INFO] 
> [INFO] ---------------< org.asynchttpclient:async-http-client >----------------
> [INFO] Building Asynchronous Http Client 2.12.3                           [3/3]
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ async-http-client ---
> [INFO] Deleting /<<PKGBUILDDIR>>/client/target
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary for Asynchronous Http Client Project 2.12.3:
> [INFO] 
> [INFO] Asynchronous Http Client Project ................... SUCCESS [  0.093 s]
> [INFO] Asynchronous Http Client Netty Utils ............... SUCCESS [  0.005 s]
> [INFO] Asynchronous Http Client ........................... SUCCESS [  0.035 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.994 s
> [INFO] Finished at: 2023-08-12T13:07:36Z
> [INFO] ------------------------------------------------------------------------
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -plibasync-http-client-java
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building async-http-client using existing ./async-http-client_2.12.3.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  async-http-client-2.12.3/client/META-INF/MANIFEST.MF
>  async-http-client-2.12.3/netty-utils/META-INF/MANIFEST.MF
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/async-http-client_2.12.3-1.diff.uzB3U2
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/async-http-client_2.12.3-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.