Bug#1045862: nailgun: Fails to build source after successful build

[Lucas Nussbaum]

Source: nailgun
Version: 0.9.3-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package nailgun
> dpkg-buildpackage: info: source version 0.9.3-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Hideki Yamane <henrich at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --buildsystem=maven
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean
> 	mh_patchpoms -pnailgun --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode clean
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Build Order:
> [INFO] 
> [INFO] nailgun-all                                                        [pom]
> [INFO] nailgun-server                                                     [jar]
> [INFO] 
> [INFO] ------------------< com.martiansoftware:nailgun-all >-------------------
> [INFO] Building nailgun-all 0.9.3-SNAPSHOT                                [1/2]
> [INFO] --------------------------------[ pom ]---------------------------------
> [WARNING] The artifact org.apache.maven.plugins:maven-clean-plugin:jar:2.5 has been relocated to org.apache.maven.plugins:maven-clean-plugin:jar:3.2.0
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ nailgun-all ---
> [INFO] Deleting /<<PKGBUILDDIR>>/target
> [INFO] 
> [INFO] -----------------< com.martiansoftware:nailgun-server >-----------------
> [INFO] Building nailgun-server 0.9.3-SNAPSHOT                             [2/2]
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ nailgun-server ---
> [INFO] Deleting /<<PKGBUILDDIR>>/nailgun-server/target
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary for nailgun-all 0.9.3-SNAPSHOT:
> [INFO] 
> [INFO] nailgun-all ........................................ SUCCESS [  0.177 s]
> [INFO] nailgun-server ..................................... SUCCESS [  0.033 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.355 s
> [INFO] Finished at: 2023-08-12T13:14:53Z
> [INFO] ------------------------------------------------------------------------
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -pnailgun
> make clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> 
> If you have a Windows binary, 'make clean' won't delete it.
> You must remove this manually.  Most users won't have MinGW
> installed - so I'd rather not delete something you can't rebuild.
> 
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f /<<PKGBUILDDIR>>/ng-nailgun
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--buildsystem=maven
>    dh_clean -O--buildsystem=maven
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building nailgun using existing ./nailgun_0.9.3.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: error: cannot represent change to ng: binary file contents changed
> dpkg-source: error: add ng in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'ng' will not be represented in diff
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/nailgun_0.9.3-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.