Bug#1047096: jenkins-json: Fails to build source after successful build

[Lucas Nussbaum]

Source: jenkins-json
Version: 2.4-jenkins-3-7
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package jenkins-json
> dpkg-buildpackage: info: source version 2.4-jenkins-3-7
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Emmanuel Bourg <ebourg at apache.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --buildsystem=maven --with javahelper
>    dh_auto_clean -O--buildsystem=maven
> 	mh_patchpoms -plibjenkins-json-java --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf -Dproperties.file.manual=/<<PKGBUILDDIR>>/debian/maven.properties org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode clean
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] --------------------< org.kohsuke.stapler:json-lib >--------------------
> [INFO] Building json-lib 2.4-jenkins-3
> [INFO] --------------------------------[ jar ]---------------------------------
> [WARNING] The artifact org.apache.maven.plugins:maven-clean-plugin:jar:2.5 has been relocated to org.apache.maven.plugins:maven-clean-plugin:jar:3.2.0
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ json-lib ---
> [INFO] Deleting /<<PKGBUILDDIR>>/target
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.223 s
> [INFO] Finished at: 2023-08-12T13:08:27Z
> [INFO] ------------------------------------------------------------------------
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -plibjenkins-json-java
>    dh_autoreconf_clean -O--buildsystem=maven
>    jh_clean -O--buildsystem=maven
>    dh_clean -O--buildsystem=maven
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building jenkins-json using existing ./jenkins-json_2.4-jenkins-3.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file jenkins-json-2.4-jenkins-3/src/main/java/net/sf/json/util/EnumMorpher.java has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  jenkins-json-2.4-jenkins-3/src/main/java/net/sf/json/JSONArray.java
>  jenkins-json-2.4-jenkins-3/src/main/java/net/sf/json/JSONObject.java
>  jenkins-json-2.4-jenkins-3/src/main/java/net/sf/json/util/EnumMorpher.java
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/jenkins-json_2.4-jenkins-3-7.diff.YXZ1Sg
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/jenkins-json_2.4-jenkins-3-7_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.