Bug#1062585: libphonenumber: NMU diff for 64-bit time_t transition

[Steve Langasek]

Source: libphonenumber
Version: 8.12.57+ds-4
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-arm at lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
libphonenumber as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for libphonenumber
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru libphonenumber-8.12.57+ds/debian/changelog libphonenumber-8.12.57+ds/debian/changelog
--- libphonenumber-8.12.57+ds/debian/changelog	2023-07-20 04:36:41.000000000 +0000
+++ libphonenumber-8.12.57+ds/debian/changelog	2024-02-02 03:11:37.000000000 +0000
@@ -1,3 +1,10 @@
+libphonenumber (8.12.57+ds-4.1~exp1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Adjust Provides for 64-bit time_t transition.
+
+ -- Steve Langasek <vorlon at debian.org>  Fri, 02 Feb 2024 03:11:37 +0000
+
 libphonenumber (8.12.57+ds-4) unstable; urgency=medium
 
   * Team upload.
diff -Nru libphonenumber-8.12.57+ds/debian/rules libphonenumber-8.12.57+ds/debian/rules
--- libphonenumber-8.12.57+ds/debian/rules	2023-07-20 04:36:41.000000000 +0000
+++ libphonenumber-8.12.57+ds/debian/rules	2024-02-02 03:11:20.000000000 +0000
@@ -1,5 +1,8 @@
 #!/usr/bin/make -f
 
+DEB_HOST_ARCH_BITS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_BITS)
+DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
+
 %:
 	dh $@
 
@@ -9,10 +12,13 @@
 protobufapi := $(shell dpkg-query -W -f '$${Provides}' libprotobuf-dev | grep -o 'protobuf-api-[^ ]*')
 
 # virtual package to represent libphonenumber and protobuf ABI
-phonenumberprotoabi := libphonenumber8-protobuf$(shell dpkg-query -W -f '$${Depends}' libprotobuf-dev | sed -n 's/.*libprotobuf\([0-9]*\) .*/\1/p')
+phonenumberprotoabi := libphonenumber8t64-protobuf$(shell dpkg-query -W -f '$${Depends}' libprotobuf-dev | sed -n 's/.*libprotobuf\([0-9]*\) .*/\1/p')
+ifneq (,$(filter 64,$(DEB_HOST_ARCH_BITS))$(filter i386,$(DEB_HOST_ARCH)))
+  phonenumberprotocompatabi := , libphonenumber8-protobuf$(shell dpkg-query -W -f '$${Depends}' libprotobuf-dev | sed -n 's/.*libprotobuf\([0-9]*\) .*/\1/p')
+endif
 
 execute_before_dh_gencontrol:
-	echo 'libphonenumber:Provides=$(phonenumberprotoabi)' >> debian/libphonenumber8.substvars
+	echo 'libphonenumber:Provides=$(phonenumberprotoabi)$(phonenumberprotocompatabi)' >> debian/libphonenumber8.substvars
 	echo 'protobuf:API=$(protobufapi)' >> debian/libphonenumber-dev.substvars
 
 override_dh_makeshlibs: