<div dir="ltr"><div><div style="font-family:verdana,sans-serif" class="gmail_default">Subject: libphonenumber FTBFS with gcc-15 and -Wbidi-char<div style="font-family:verdana,sans-serif" class="gmail_default">Package: libphonenumber8</div><div style="font-family:verdana,sans-serif" class="gmail_default">Source: libphonenumber<br>X-Debbugs-Cc: <a href="mailto:john.chittum@canonical.com" target="_blank">john.chittum@canonical.com</a><br>Version: 8.13.51+ds-4.2</div><div style="font-family:verdana,sans-serif" class="gmail_default">Severity: normal</div></div><br><div style="font-family:verdana,sans-serif" class="gmail_default">attempting to compile libphonenumber with Ubuntu defaults with gcc-15 results in a FTBFS. This is due to -Werror=bidi-char being set by default. -Wbidi-char raises <br><br>/usr/bin/c++ -DI18N_PHONENUMBERS_USE_ALTERNATE_FORMATS -DI18N_PHONENUMBERS_USE_ICU_REGEXP -DI18N_PHONENUMBERS_USE_TR1_UNORDERED_MAP -I/<<PKGBUILDDIR>>/cpp/src -I/<<PKGBUILDDIR>>/cpp/test -g -O2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/libphonenumber-8.13.51+ds-4.2build1 -Wdate-time -D_FORTIFY_SOURCE=3   -Wall -Werror -MD -MT CMakeFiles/libphonenumber_test.dir/test/phonenumbers/phonenumberutil_test.cc.o -MF CMakeFiles/libphonenumber_test.dir/test/phonenumbers/phonenumberutil_test.cc.o.d -o CMakeFiles/libphonenumber_test.dir/test/phonenumbers/phonenumberutil_test.cc.o -c /<<PKGBUILDDIR>>/cpp/test/phonenumbers/phonenumberutil_test.cc<br>
/<<PKGBUILDDIR>>/cpp/test/phonenumbers/phonenumberutil_test.cc:1627:43: error: found problematic Unicode character ‘U+200F (RIGHT-TO-LEFT MARK)’ [-Werror=bidi-chars=]<br>
 1627 |                         /* "(650) 253-0000<U+200F>" */, &extracted_number);<br>
      |                                           ^~~~~~~~<br>
cc1plus: all warnings being treated as errors<br><br></div><div style="font-family:verdana,sans-serif" class="gmail_default">Where <U+200F> in the code is the properly formatted Unicode character. <br><br></div><div style="font-family:verdana,sans-serif" class="gmail_default">The test correctly encodes it, and only the comment contains the unicode literal. However, -Wbidi-char checks comments as well, as that is a source for a Trojan Source attack. pragma comments also cannot disable bidi-char when set via cli or envvar. <br><br></div><div style="font-family:verdana,sans-serif" class="gmail_default">Attached is the proposed patch going into Ubuntu, which escapes the comment. This is also reported upstream with Google, where I suggest escaping as well.<br><br></div><div style="font-family:verdana,sans-serif" class="gmail_default">Upstream: <a href="https://partnerissuetracker.corp.google.com/issues/446931058">https://partnerissuetracker.corp.google.com/issues/446931058</a><br></div><div style="font-family:verdana,sans-serif" class="gmail_default">Ubuntu Bug: <a href="https://bugs.launchpad.net/ubuntu/+source/libphonenumber/+bug/2124964">https://bugs.launchpad.net/ubuntu/+source/libphonenumber/+bug/2124964</a></div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><font face="verdana,sans-serif">-----------------------<br></font></div><div><font face="verdana,sans-serif">Dr. John Chittum</font></div><div><font face="verdana,sans-serif">Engineering Manager, Canonical, Debcrafters</font></div></div></div></div></div></div>