[Pkg-javascript-commits] [node-leveldown] 235/492: fix NewInstance args handling, closes #14

[Andrew Kelley]

This is an automated email from the git hooks/post-receive script.

andrewrk-guest pushed a commit to annotated tag rocksdb-0.10.1
in repository node-leveldown.

commit 8de528ecdf90bee07aef2ddef6788c46d97dd29c
Author: Rod Vagg <rod at vagg.org>
Date:   Mon Feb 25 09:12:40 2013 +1100

    fix NewInstance args handling, closes #14
---
 src/database.cc | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/database.cc b/src/database.cc
index 86835e8..677af46 100644
--- a/src/database.cc
+++ b/src/database.cc
@@ -161,13 +161,15 @@ v8::Handle<v8::Value> Database::New (const v8::Arguments& args) {
 v8::Handle<v8::Value> Database::NewInstance (const v8::Arguments& args) {
   v8::HandleScope scope;
 
-  v8::Handle<v8::Value> argv[args.Length()];
+  v8::Local<v8::Object> instance;
 
-  for (int i = 0; i < args.Length(); i++)
-    argv[i] = args[i];
-
-  v8::Local<v8::Object> instance =
-      constructor->NewInstance(args.Length(), argv);
+  if (args.Length() == 0) {
+    v8::Handle<v8::Value> argv[0];
+    instance = constructor->NewInstance(0, argv);
+  } else {
+    v8::Handle<v8::Value> argv[] = { args[0] };
+    instance = constructor->NewInstance(1, argv);
+  }
 
   return scope.Close(instance);
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/node-leveldown.git