[Pkg-javascript-commits] [sockjs-client] 152/350: Don't leak globals from jsonp receiver

[tonnerre at ancient-solutions.com]

This is an automated email from the git hooks/post-receive script.

tonnerre-guest pushed a commit to branch upstream
in repository sockjs-client.

commit 22af6d7ade581d4a2fe7ef875c4c36da0e88a5f1
Author: Bryce Kahle <bkahle at gmail.com>
Date:   Thu Oct 16 19:51:47 2014 -0400

    Don't leak globals from jsonp receiver
---
 lib/transport/receiver/jsonp.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/transport/receiver/jsonp.js b/lib/transport/receiver/jsonp.js
index 4678737..c7bebfe 100644
--- a/lib/transport/receiver/jsonp.js
+++ b/lib/transport/receiver/jsonp.js
@@ -45,7 +45,6 @@ JsonpReceiver.scriptErrorTimeout = 1000;
 JsonpReceiver.prototype._callback = function (data) {
   debug('_callback', data);
   this._cleanup();
-  delete global[utils.WPrefix][this.id];
 
   if (this.aborting) {
     return;
@@ -83,6 +82,7 @@ JsonpReceiver.prototype._cleanup = function () {
         script.onload = script.onclick = null;
     this.script = null;
   }
+  delete global[utils.WPrefix][this.id];
 };
 
 JsonpReceiver.prototype._scriptError = function () {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/sockjs-client.git