[Pkg-javascript-devel] New jquery-lazyload version 1.8.3 - please review

Emilien Klein emilien+debian at klein.st
Sun Dec 30 22:23:28 UTC 2012


Hi team,

I've updated the jquery-lazyload package in our Git repo [0] for the
newest upstream version. I'd appreciate a review, and sponsored upload
if all looks good.

The biggest change with the previous packaged version (which wasn't
yet uploaded) is that the uncertainty around the license for the
images included in the upstream tarball has been resolved:
- As it turned out, the thumbnails were not properly licensed: quote
from [1]: "The small images are bit problematic. They were taken
almost 10 years ago in wakeboard competition I was organizing. They
are not taken by me and I also do not even remember the name of the
photographer."), those files have been removed by upstream
- The other images are now explicitly licensed under a CC license
(specified in the README.textile file)

As follow up on our review discussion for the previous 1.8.0 version,
I had prepared a get-orig-source target in debian/rules (attached for
reference) that removed all the images, since they were not clearly
licensed. Another step was the removal of the minified files. Since I
was going to repackage [for the images], I'd remove those files as
well, but I don't think that those files by themselves justify a
repackaging. Remember that they are not used in the binary package, as
the file gets minified in the build process using uglifyjs... I assume
this is OK with our team's policy, please comment if you feel not.

Thanks, and enjoy the last day of 2012!
   +Emilien

[0] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-lazyload.git
[1] https://github.com/tuupola/jquery_lazyload/issues/73#issuecomment-11086261
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rules
Type: application/octet-stream
Size: 1183 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20121230/e8360ecd/attachment.obj>


More information about the Pkg-javascript-devel mailing list