[Pkg-javascript-devel] Bug#927254: Bug#927254: libjs-vue-router: ships node module instead of browser one

[Xavier]

Le 17/04/2019 à 00:44, Dmitry Bogatov a écrit :
> 
> Package: libjs-vue-router
> Version: 3.0.2+ds-1
> Severity: normal
> 
> Dear Maintainer,
> 
> I am working on packaging Laminar CI system, and libjs-vue-router is one
> of its dependencies. Upstream build system of Laminar downloads its
> dependencies from web, but to comply with Policy, I patched it to use
> local files. Unfortunately, it did not work.
> 
> Upstream author of Laminar (in CC) kindly provided following information:
> 
>   OK this is a problem. It looks like the libjs-vue-router package is not
>   really a pure javascript package but actually a node.js one (probably
>   should be named node-vue-router). It even lists nodejs in its dependencies:
>   https://packages.debian.org/sid/libjs-vue-router
> 
>   I tried all the variations under /usr/share/javascript/vue-router, all fail
>   in some variation of the same issue. I don't know how it worked for me last
>   time, probably I made a mistake and accidentally used the "browser"
>   vue-router js file.
> 
>   If you use the latest "browser" version of vue-router, available here:
>   https://unpkg.com/vue-router@3.0.3/dist/vue-router.js and linked from their
>   installation page:
>   https://router.vuejs.org/installation.html#direct-download-cdn then it
>   works. So I think what should happen, at least ideally, is that the
>   existing libjs-vue-router package should be renamed node-vue-router (and it
>   should not symlink from /usr/share/javascript/vue-router to
>   ../../lib/nodejs/vue-router/dist, and it should depend on node-vue not
>   libjs-vue), and a new package named libjs-vue-router should be created
>   containing the "browser" version. This would seem to be consistent with
>   Debian Javascript packaging as I understand it
> 
> I have no expertise to comment on this, but can you please consider this
> argument?

Provided files are not node-* ones but recompiled using rollup. Could
you check if Laminar works well with
https://unpkg.com/vue-router@3.0.2/dist/vue-router.js file ? (same
version than in Buster)