[Pkg-javascript-devel] Bug#1008200: node-send: patched node-mime-types cause problems for other reverse-dependencies

[Nilesh Patra]

Package: node-send
Version: 0.17.2-2
Severity: important
X-Debbugs-Cc: merkys at debian.org

Hi Yadd,

node-send is patched[1] to use node-mime-types instead of node-mime.
However, this change is breaking node-shiny-server[2] build (not yet uploaded)
with:

| TypeError: send.mime.define is not a function
|    at Object.<anonymous> (/home/nilesh/packages/shinyserv/shiny-server/lib/router/directory-router.js:27:11)
|    at Module._compile (internal/modules/cjs/loader.js:999:30)
|    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
|    at Module.load (internal/modules/cjs/loader.js:863:32)

mime-types used to have a "define" function which has been removed in version2 of the same.
It is still not entirely clear to me as to why the patching was needed.
If possible, can you revert it to use proper node-mime?

If you happen to drop that patch, some tests fail due to new node-mime API; these can be
fixed with a simple patch attached with this bug report.


[1]: https://salsa.debian.org/js-team/node-send/-/blob/master/debian/patches/0001-use_ms_from_debug.patch#L15
[2]: https://salsa.debian.org/science-team/shiny-server

Regards,
Nilesh

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.14.0-2-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages node-send depends on:
pn  node-debug         <none>
pn  node-depd          <none>
pn  node-encodeurl     <none>
pn  node-escape-html   <none>
pn  node-etag          <none>
pn  node-fresh         <none>
pn  node-http-errors   <none>
pn  node-mime-types    <none>
pn  node-on-finished   <none>
pn  node-range-parser  <none>

node-send recommends no packages.

node-send suggests no packages.